Skip to content

fix: handle JS files when allowJs and checkJs options are set to true #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: handle JS files when allowJs and checkJs options are set to true #71

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 25 additions & 8 deletions cli.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,23 +26,40 @@ const argsProjectIndex = args.findIndex(arg =>
const argsProjectValue =
argsProjectIndex !== -1 ? args[argsProjectIndex + 1] : undefined

const files = args.filter(file => /\.(ts|tsx)$/.test(file))
// Load existing config
const tsconfigPath = argsProjectValue || resolveFromRoot('tsconfig.json')
const tsconfigContent = fs.readFileSync(tsconfigPath).toString()
// Use 'eval' to read the JSON as regular JavaScript syntax so that comments are allowed
let tsconfig = {}
eval(`tsconfig = ${tsconfigContent}`)

const handleJsFiles = tsconfig.compilerOptions.allowJs && tsconfig.compilerOptions.checkJs

// if we allow AND check js files, test for js|jsx extensions as well, otherwise they will get passed
// along with other arguments and we will get the error that -p cannot be used alongside with the
// files option
const files = handleJsFiles
? args.filter(file => /\.(ts|tsx|js|jsx)$/.test(file))
: args.filter(file => /\.(ts|tsx)$/.test(file));

if (files.length === 0) {
process.exit(0)
}

const remainingArgsToForward = args.slice().filter(arg => !files.includes(arg))
const remainingArgsToForward = args.slice().filter(arg => {
// discard js filenames if we do not handle js files
if (!handleJsFiles && /\.(js|jsx)$/.test(arg)) {
return false;
}

return !files.includes(arg)
})

if (argsProjectIndex !== -1) {
remainingArgsToForward.splice(argsProjectIndex, 2)
}

// Load existing config
const tsconfigPath = argsProjectValue || resolveFromRoot('tsconfig.json')
const tsconfigContent = fs.readFileSync(tsconfigPath).toString()
// Use 'eval' to read the JSON as regular JavaScript syntax so that comments are allowed
let tsconfig = {}
eval(`tsconfig = ${tsconfigContent}`)


// Write a temp config file
const tmpTsconfigPath = resolveFromRoot(`tsconfig.${randomChars()}.json`)
Expand Down