fixed handling of stale nonces in the HTTP Digest Auth implementation #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The stale=true attribute was not sent in the resulting challenge that the server sends, so clients/browsers would unnecessarily ask for the credentials again.
|
@gvalkov ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
stale=trueattribute was not sent in the resulting challenge that the server sends, so clients/browsers would unnecessarily ask for the credentials again.You may want to edit this change if you disagree with the way I pass on the information that the nonce is stale. Actually, I do not understand why you are throwing
AuthErrorinDigestAuthMixin.verify_opaque()in the first place instead of always throwingDigestAuthMixin.SendChallenge().