-
Notifications
You must be signed in to change notification settings - Fork 46
[RTN-2065] feat(feedback): add multiple paragraphs in description #900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
| color: #231B22; | ||
| font-family: Rubik; | ||
| font-weight: 400; | ||
| margin-top: 16px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this old snap be changed? I imagine the change shouldn't change the old interface (with only 1 paragraph) to avoid the risk of changing what we already have currently 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @flaviafmoraes 👋
What happened is that there was originally only one <Text /> with that margin.
I added a <Box /> around it to allow rendering a list of <Text /> components.
So I removed the margin from the <Text /> and moved it to the <Box />, which is why there’s a style change in the <Text />.


Description 📄
This pull request enhances the
Feedbackcomponent to support multiple paragraphs in its description by allowing thedescriptionprop to accept an array of strings. It also updates the documentation, type definitions, and tests to reflect this new capability.Platforms 📲
Type of change 🔍
How Has This Been Tested? 🧪
Access the feedback component: http://localhost:8000/components/feedback
Now you can add a string to the description prop or an array of strings.
Checklist: 🔍
Screenshots 📸