Skip to content

Conversation

@matheushdsbr
Copy link
Contributor

JIRA Issue

Description 📄

This pull request enhances the Feedback component to support multiple paragraphs in its description by allowing the description prop to accept an array of strings. It also updates the documentation, type definitions, and tests to reflect this new capability.

Platforms 📲

  • Web
  • Mobile

Type of change 🔍

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested? 🧪

Access the feedback component: http://localhost:8000/components/feedback

Now you can add a string to the description prop or an array of strings.

  • Unit Test
  • Snapshot Test

Checklist: 🔍

  • My code follows the contribution guide of this project Contributing Guide
  • Layout matches design prototype: FIGMA
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Screenshots 📸

Screenshot 2025-09-19 at 2 48 00 PM

@matheushdsbr matheushdsbr changed the title [RTN-2025] feat(feedback): add multiple paragraphs in description [RTN-2065] feat(feedback): add multiple paragraphs in description Sep 19, 2025
@matheushdsbr matheushdsbr self-assigned this Sep 19, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 6, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
3 Security Hotspots

See analysis details on SonarQube Cloud

color: #231B22;
font-family: Rubik;
font-weight: 400;
margin-top: 16px;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this old snap be changed? I imagine the change shouldn't change the old interface (with only 1 paragraph) to avoid the risk of changing what we already have currently 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @flaviafmoraes 👋
What happened is that there was originally only one <Text /> with that margin.
I added a <Box /> around it to allow rendering a list of <Text /> components.
So I removed the margin from the <Text /> and moved it to the <Box />, which is why there’s a style change in the <Text />.

@flaviafmoraes flaviafmoraes merged commit ebb9dd7 into master Oct 14, 2025
2 of 3 checks passed
@flaviafmoraes flaviafmoraes deleted the RTN-2065 branch October 14, 2025 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants