Skip to content

Conversation

@vedina
Copy link
Contributor

@vedina vedina commented Oct 30, 2025

resolves #233

@vedina vedina requested a review from kerberizer October 30, 2025 15:24
@github-actions
Copy link

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  src/ramanchada2/protocols/calibration
  ycalibration.py 181-182, 185
  src/ramanchada2/spectrum
  spectrum.py
Project Total  

This report was generated by python-coverage-comment-action

@kerberizer
Copy link
Member

Is this still a WIP, or was it created as draft by mistake? Should we merge it, should we create a new release (and if yes, a patch, or minor)?

@vedina
Copy link
Contributor Author

vedina commented Oct 31, 2025

Draft is on purpose, I want to check few more things, but travelling at the moment. Not urgent to merge, it did not improve what I was hoping to. Should be minor version

@vedina vedina self-assigned this Nov 2, 2025
@vedina vedina marked this pull request as ready for review November 2, 2025 06:25
@vedina
Copy link
Contributor Author

vedina commented Nov 2, 2025

Okay, let's merge it, but not necessary to do release immediately. We'll eventually get some feedback next 2 weeks on the calibration workflow/rc2 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use spline interpolation in YCalibrationComponent

3 participants