Fix for blurry images from WEBP input and small output dimensions#368
Merged
h2non merged 2 commits intoh2non:masterfrom Aug 7, 2021
Merged
Fix for blurry images from WEBP input and small output dimensions#368h2non merged 2 commits intoh2non:masterfrom
h2non merged 2 commits intoh2non:masterfrom
Conversation
|
good job, that helps me. please merge it |
Contributor
Author
|
Looks like this project is abandoned... |
|
bad news, there are so many PR waiting for merge。 |
|
good job, that helps me. please merge it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will fix blurry images if the input is in webp format and the output is relativly small in his dimensions. This will fix issues #220, #339 makes #222 obsolet. This will also fix h2non/imaginary#240.
The underlying issue is, that the
factorcomming out fromsupportsShrinkOnLoadis too high.transformImagehas then a too largeshrinkand the image gets blurred.I have no good idea, how to put that in a unit test, since the image output may differ on plattforms.
I did some manual testing with a lot of different output resolutions and compared the old with the new code. All blurring is gone.
shrinkOnloaduses for WEBP now the same logic as for JPEG.