Force serialization of dtrace
-G
invocations.
#561
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of ubuntu focal (20.04),
systemtap-sdt-dev
version4.2-3ubuntu0.1
, the temporary files collide in a build with concurrency (make
-j
).The description in the systemtap repo commit 0de9020c9 describes the problem. From what I can tell, that commit introduced the version that we see on focal and it has the problem that we run into in a parallel build of h2o, because as the description mentions:
dtrace
does not take all that long to run, the impact that serializing alldtrace
command invocations has on the build time is imperceptible.The eventual fix in 05c8fa6a5 seems to be a better fix because it looks like it checks for collisions, though I have not tested that version.