Skip to content

Force serialization of dtrace -G invocations. #561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jhatala
Copy link

@jhatala jhatala commented Feb 16, 2025

As of ubuntu focal (20.04), systemtap-sdt-dev version 4.2-3ubuntu0.1, the temporary files collide in a build with concurrency (make -j).

The description in the systemtap repo commit 0de9020c9 describes the problem. From what I can tell, that commit introduced the version that we see on focal and it has the problem that we run into in a parallel build of h2o, because as the description mentions:

Note: this still leaves open a race in the case of 2 dtrace processes with identical input/output paths.

dtrace does not take all that long to run, the impact that serializing all dtrace command invocations has on the build time is imperceptible.

The eventual fix in 05c8fa6a5 seems to be a better fix because it looks like it checks for collisions, though I have not tested that version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant