Open
Conversation
Contributor
samukweku
commented
Apr 3, 2023
samukweku
commented
- WIP Refactor Expr architecture #2562
Contributor
|
@samukweku I suggest we fix all the issues with the existing PRs and make them green, before opening new ones. Otherwise, it is complicated to keep track of all of them. |
Contributor
Author
|
@oleksiyskononenko all good; I'll wait for your feedback on the other PRs |
Contributor
|
@samukweku I'm off this week, but it is better to make PRs green first. |
samukweku
force-pushed
the
samukweku/trigonometric_fexpr
branch
from
0dc72a5 to
6cd4f71
Compare
Contributor
Author
|
@oleksiyskononenko since i've got some time, I'll work on some more issues, and mark them as draft, pending when the other PRs are reviewed. |
Contributor
|
@samukweku some PRs are still red, you might want to take a look at them. |
samukweku
force-pushed
the
samukweku/trigonometric_fexpr
branch
from
6cd4f71 to
463c0d8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.