Skip to content

GH-16319 Implement KNN API [nocheck] #16474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

GH-16319 Implement KNN API [nocheck] #16474

wants to merge 5 commits into from

Conversation

maurever
Copy link
Contributor

@maurever maurever commented Jan 8, 2025 •
edited
Loading

Issue: #16319

@maurever maurever requested a review from valenad1 January 8, 2025 15:08
@maurever maurever self-assigned this Jan 8, 2025
@maurever maurever marked this pull request as draft January 8, 2025 15:08
@maurever maurever mentioned this pull request Jan 8, 2025
Open
3 tasks
@maurever maurever added this to the 3.48.0.1 milestone Jan 15, 2025
@maurever maurever force-pushed the maurever_GH-16319_knn_api branch 3 times, most recently from 5d41630 to 2e09300 Compare January 17, 2025 14:55
@maurever maurever marked this pull request as ready for review January 30, 2025 09:27
@maurever maurever changed the title GH-16319 Implement KNN API GH-16319 Implement KNN API [nocheck] Jan 30, 2025
@maurever maurever force-pushed the maurever_GH-16319_knn_api branch from e410c48 to fea2d97 Compare February 24, 2025 10:51
@valenad1 valenad1 force-pushed the maurever_GH-16319_knn_api branch from fea2d97 to 702eb7e Compare February 26, 2025 09:22
@valenad1 valenad1 force-pushed the maurever_GH-16319_knn_api branch from 702eb7e to 67951ef Compare February 27, 2025 13:59
@valenad1
Copy link
Collaborator

LGTM, before we proceed with merge. I would like to assure how it behaves on large data. Could you run some performance test?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valenad1 valenad1 Awaiting requested review from valenad1

At least 1 approving review is required to merge this pull request.

Assignees

@maurever maurever

Labels
None yet
Projects
None yet
Milestone
3.48.0.1
Development

Successfully merging this pull request may close these issues.
2 participants
@maurever @valenad1