GH-16319 Implement KNN API [nocheck] #16474
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maurever
force-pushed
the
maurever_GH-16319_knn_api
branch
3 times, most recently
from
5d41630 to
2e09300
Compare
maurever
changed the title
maurever
force-pushed
the
maurever_GH-16319_knn_api
branch
from
e410c48 to
fea2d97
Compare
valenad1
force-pushed
the
maurever_GH-16319_knn_api
branch
from
fea2d97 to
702eb7e
Compare
valenad1
force-pushed
the
maurever_GH-16319_knn_api
branch
from
702eb7e to
67951ef
Compare
|
LGTM, before we proceed with merge. I would like to assure how it behaves on large data. Could you run some performance test? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #16319