GH-16592 Fix NPE when scoring CoxPH mojo from h2o 3.32.x.x#16591
Merged
valenad1 merged 2 commits intorel-3.46.0from Apr 10, 2025
Merged
GH-16592 Fix NPE when scoring CoxPH mojo from h2o 3.32.x.x#16591valenad1 merged 2 commits intorel-3.46.0from
valenad1 merged 2 commits intorel-3.46.0from
Conversation
Collaborator
Hi @Mathanraj-Sharma , just realized.. what if we traing CoxPH model only with categorical columns? |
ea67b29 to
507d6ae
Compare
Member
Author
|
@valenad1 fix works for model trained using categorical features only as well |
507d6ae to
26cd3ab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16592
CoxPH mojo models generated using
3.32.x.xthrows NPE when using withh2o >= 3.42.0.4The issue mainly occurs since
num_numerical_columnsandnum_offsetsare absent in CoxPH mojo from older h2o3 versions.I am using the
-1as default fornum_numerical_columns( assuming number of numerical columns won't be less than0in any cases) and scoring based on it.ref: https://support.h2o.ai/a/tickets/110207