GH-16590 Accept zero as offset for xgb models trained with offset#16605
Merged
Mathanraj-Sharma merged 1 commit intorel-3.46.0from May 7, 2025
Merged
GH-16590 Accept zero as offset for xgb models trained with offset#16605Mathanraj-Sharma merged 1 commit intorel-3.46.0from
Mathanraj-Sharma merged 1 commit intorel-3.46.0from
Conversation
valenad1
previously approved these changes
May 7, 2025
Collaborator
valenad1
left a comment
There was a problem hiding this comment.
LGTM, thank you!
Can you please rebase it on top of rel-3.46.0.
aa639d2 to
76bb62c
Compare
Member
Author
|
@valenad1 jenkins build is failing with below error, I guess it is irrelevant to the changes here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #16590
xgb-Copy2.pdf