Skip to content

GH-16590 Accept zero as offset for xgb models trained with offset#16605

Merged
Mathanraj-Sharma merged 1 commit intorel-3.46.0from
MR/master/issue-16590
May 7, 2025
Merged

GH-16590 Accept zero as offset for xgb models trained with offset#16605
Mathanraj-Sharma merged 1 commit intorel-3.46.0from
MR/master/issue-16590

Conversation

@Mathanraj-Sharma
Copy link
Copy Markdown
Member

valenad1
valenad1 previously approved these changes May 7, 2025
Copy link
Copy Markdown
Collaborator

@valenad1 valenad1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

Can you please rebase it on top of rel-3.46.0.

@Mathanraj-Sharma Mathanraj-Sharma changed the base branch from master to rel-3.46.0 May 7, 2025 12:33
@Mathanraj-Sharma Mathanraj-Sharma dismissed valenad1’s stale review May 7, 2025 12:33

The base branch was changed.

@Mathanraj-Sharma Mathanraj-Sharma force-pushed the MR/master/issue-16590 branch from aa639d2 to 76bb62c Compare May 7, 2025 12:49
@Mathanraj-Sharma Mathanraj-Sharma requested a review from valenad1 May 7, 2025 12:50
Copy link
Copy Markdown
Collaborator

@valenad1 valenad1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@Mathanraj-Sharma
Copy link
Copy Markdown
Member Author

@valenad1 jenkins build is failing with below error, I guess it is irrelevant to the changes here

Found unhandled hudson.remoting.ProxyException exception:
jenkins.util.io.CompositeIOException: Unable to delete '/home/jenkins/workspace/H2O-3_h2o-3-ci-tests_PR-[1](http://jenkins.h2o.local:8080/job/H2O-3/job/h2o-3-ci-tests/job/PR-16605/3/pipeline-console/?start-byte=0&selected-node=19#log-1)6605/h2o-3'. Tried 3 times (of a maximum of 3) waiting 0.1 sec between attempts. (Discarded 20810 additional exceptions)
	Jenkins v2.495//jenkins.util.io.PathRemover.forceRemoveRecursive(PathRemover.java:96)
	Jenkins v2.495//hudson.Util.deleteRecursive(Util.java:334)
	Jenkins v[2](http://jenkins.h2o.local:8080/job/H2O-3/job/h2o-3-ci-tests/job/PR-16605/3/pipeline-console/?start-byte=0&selected-node=19#log-2).495//hudson.FilePath$DeleteRecursive.invoke(FilePath.java:1457)
	Jenkins v2.495//hudson.FilePath$DeleteRecursive.invoke(FilePath.java:1452)
	Jenkins v2.495//hudson.FilePath$FileCallableWrapper.call(FilePath.java:[3](http://jenkins.h2o.local:8080/job/H2O-3/job/h2o-3-ci-tests/job/PR-16605/3/pipeline-console/?start-byte=0&selected-node=19#log-3)593)
	hudson.remoting.UserRequest.perform(UserRequest.java:225)
	hudson.remoting.UserRequest.perform(UserRequest.java:50)
	hudson.remoting.Request$2.run(Request.java:391)
	hudson.remoting.InterceptingExecutorService.lambda$wrap$0(InterceptingExecutorService.java:81)
	java.base/java.util.concurrent.FutureTask.run(FutureTask.java:317)
	java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:11[4](http://jenkins.h2o.local:8080/job/H2O-3/job/h2o-3-ci-tests/job/PR-16605/3/pipeline-console/?start-byte=0&selected-node=19#log-4)4)
	java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)

@Mathanraj-Sharma Mathanraj-Sharma merged commit f9acd4b into rel-3.46.0 May 7, 2025
6 of 9 checks passed
@Mathanraj-Sharma Mathanraj-Sharma deleted the MR/master/issue-16590 branch May 7, 2025 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

H2O3 Mojo model scoring fails in python when offset column is used

2 participants