Skip to content

Fixing macos CI #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zkytony merged 3 commits into from
Oct 25, 2025
Merged

Fixing macos CI #86

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7ebf1f6
try building pomdp-solve and sarsop on arm64
zkytony Oct 25, 2025
0a2c9a3
try this
zkytony Oct 25, 2025
1f6f81f
try again
zkytony Oct 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 16 additions & 8 deletions .github/workflows/macos.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,27 +25,35 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-python@v5
with:
python-version: '3.10'
python-version: '3.11'
- name: Build dependencies
shell: bash
run: |
# Install pomdp-solve macOS binary
wget -P thirdparty https://www.pomdp.org/code/pomdp-solve-os-x.bin
chmod +x thirdparty/pomdp-solve-os-x.bin
# pomdp-solve (native, via autotools)
mkdir -p thirdparty
curl -L https://www.pomdp.org/code/pomdp-solve-5.5.tar.gz -o thirdparty/pomdp-solve-5.5.tar.gz
tar -xzf thirdparty/pomdp-solve-5.5.tar.gz -C thirdparty
mv thirdparty/pomdp-solve-5.5 thirdparty/pomdp-solve
( cd thirdparty/pomdp-solve && ./configure )
make -C thirdparty/pomdp-solve/src
ln -sf "$(pwd)/thirdparty/pomdp-solve/src/pomdp-solve" thirdparty/pomdp-solve.bin

# Build and install SARSOP
# APPL / SARSOP (strip x86-only flags on arm64)
git clone https://github.com/personalrobotics/appl.git thirdparty/appl
# Fix Arm build (remove -mfpmath=sse) and declare implict functions
git -C thirdparty/appl apply ../../tests/appl.patch
if [[ $(uname -m) == "arm64" ]]; then
find thirdparty/appl/src -name "Makefile*" -print0 \
| xargs -0 sed -i '' -E 's/ -m(sse|sse2|ssse3|sse4[^ ]*)//g; s/ -mfpmath=sse//g; s/ -march=[^ ]+//g; s/ -mtune=[^ ]+//g'
fi
make -C thirdparty/appl/src
make -C thirdparty/appl/src install
- name: Install dependencies
run: |
python -m pip install --upgrade pip
pip install -e .
- name: Test
working-directory: .
run: |
export POMDP_SOLVE_PATH=./thirdparty/pomdp-solve-os-x.bin
export POMDP_SOLVE_PATH=./thirdparty/pomdp-solve.bin
export POMDPSOL_PATH=./thirdparty/appl/bin/pomdpsol
export POMDPCONVERT_PATH=./thirdparty/appl/src/pomdpconvert
python tests/test_all.py