Skip to content

fix(cdp): expose content editing host accessibility values - #731

Open
enginespot wants to merge 1 commit into
h4ckf0r0day:mainfrom
enginespot:fix/contenteditable-ax-value
Open

fix(cdp): expose content editing host accessibility values#731
enginespot wants to merge 1 commit into
h4ckf0r0day:mainfrom
enginespot:fix/contenteditable-ax-value

Conversation

@enginespot

Copy link
Copy Markdown
Contributor

What changed

Fixes #730.

Accessibility value computation now exposes the current DOM text for content editing hosts.

The implementation follows contenteditable keyword and inheritance semantics, including true, the empty keyword, plaintext-only, false, invalid inherited values, and a nested host re-enabled inside a disabled region. Only the editing host receives the value, so editable descendants do not duplicate it. Native input, textarea, and select value handling remains unchanged.

Validation

  • cargo nextest run -p obscura-cdp: 126 passed, 3 skipped
  • Focused content editing host AX value regression test: passed

Rendering

Not applicable.

Performance

AX value computation walks ancestors only for non-native candidate elements while building the accessibility tree. The walk is bounded by DOM depth and introduces no persistent state or new dependency.

Checklist

  • The change is focused and does not remove existing behavior without justification.
  • Tests cover the failure or feature.
  • Existing tests pass, including render and no-render configurations when affected.
  • I checked for CPU, latency, and memory regressions.
  • Public API or user-facing behavior changes are documented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Accessibility tree omits values for content editing hosts

1 participant