Maintenance - #11
Merged
Merged
Conversation
3.9 is EOL in a few days, 3.10 is the new min version.
It was marked as returning `BufferT | ViewT` but only BufferT was bound in the method's context, ViewT seems like a mistake that is not valid and could never be returned.
Some ignored type errors are no longer errors, some correct things are now errors and need ignoring.
Ruff and mypy complain about Generic not being the last base class of JSArrayBuffer.
Mypy was inferring the return type of read_js_array_buffer as ABC instead of the union of the 3 arguments. (ABC is a base class of all 3 arguments passed at at the call site.) Separating the 3 arguments into 3 separate type vars seems to help it keep the 3 types distinct rather than resolve the common ancestor. Additionally, mypy also seems to need an explicit subscript to declare the generic type of `JSArrayBuffer[ReadableBinary]`, even though `ReadableBinary` *is* the default type of the typevar, so this shouldn't be necessary.
Because we're not using mypy's `python_version` option to run on a single version, I think it makes sense to run mypy with all versions. We use quite a bit of conditional typing, and these conditional types could be wrong on one branch but not another.
It now builds a node 24 and deno 2 image, and uses the latest dnt to build the npm package from the deno package src.
We now support running the integration test echoserver for node 24 and deno 2 using `--profile=unstable` compose option. They're not enabled by default, because integration tests are failing against them (we don't yet support node's buffer view extension encoding for float 16 views). To support a dynamic number of echoservers, the integration_test service no longer explicitly uses depends_on to list echoserver services. Instead, we use `--wait` when starting echoservers in CI to ensure they're healthy before running the tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
General maintenance.