test: fix flaky fail in JSObjectComparisonMachine - #9
Merged
Conversation
Hypothesis found a failure scenario in the stateful property test using property '00'. The test's model was incorrectly treating it as an integer property, when in fact it should be (and is) treated as a string property. This caused the test to fail incorrectly. The test now uses the well-tested normalise_property_key() function instead of int() to distinguish integer from non-integer properties.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hypothesis found a failure scenario in the stateful property test using property '00'. The test's model was incorrectly treating it as an integer property, when in fact it should be (and is) treated as a string property. This caused the test to fail incorrectly.
The test now uses the well-tested normalise_property_key() function instead of int() to distinguish integer from non-integer properties.