Add accessibility docs#3410
Open
Mobey-eth wants to merge 2 commits into
Open
Conversation
roblarsen
requested changes
Apr 22, 2026
| @@ -0,0 +1,108 @@ | |||
| [HTML5 Boilerplate homepage](https://html5boilerplate.com/) | [Documentation | |||
Member
There was a problem hiding this comment.
Great start on this! Since HTML5 Boilerplate is often a first stop for developers, I think we should aim for this guide to be 'A11y 101.'
Currently, the section on ARIA assumes the reader already knows what it is and when to use it. Define it before mentioning it. I'd also suggest moving the complex ARIA examples to the end (or better yet, removing them entirely) and focusing first on the basics already present in the Boilerplate, like the lang attribute and the .visually-hidden class.
Author
|
Hi, thanks for the insights. I'll update my PR with your suggestions!
…On Wed, Apr 22, 2026 at 9:36 PM Rob Larsen ***@***.***> wrote:
***@***.**** requested changes on this pull request.
------------------------------
In docs/accessibility.md
<#3410?email_source=notifications&email_token=AXNBFS7HBQC35WOZSIQ3HIL4XEUNXA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTIMJVG43TQNZYHE22M4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2K64DSL5ZGK5TJMV3V6Y3MNFRWW#discussion_r3126767280>
:
> @@ -0,0 +1,108 @@
+[HTML5 Boilerplate homepage](https://html5boilerplate.com/) | [Documentation
Great start on this! Since HTML5 Boilerplate is often a first stop for
developers, I think we should aim for this guide to be 'A11y 101.'
Currently, the section on ARIA assumes the reader already knows what it is
and when to use it. Define it before mentioning it. I'd also suggest moving
the complex ARIA examples to the end (or better yet, removing them
entirely) and focusing first on the basics already present in the
Boilerplate, like the lang attribute and the .visually-hidden class.
—
Reply to this email directly, view it on GitHub
<#3410?email_source=notifications&email_token=AXNBFSZOXFYT2MZ3XQUMU3D4XEUNXA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTIMJVG43TQNZYHE22M4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2L24DSL5ZGK5TJMV3V63TPORUWM2LDMF2GS33OONPWG3DJMNVQ#pullrequestreview-4157787895>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AXNBFSZTMA64IXSLVTKYYK34XEUNXAVCNFSM6AAAAACYCBJHDOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHM2DCNJXG44DOOBZGU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Author
|
Updated this to keep it more introductory. I moved the guide toward the basics already in the Boilerplate, added a plain definition of ARIA, and removed the more advanced examples. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
Closes #3038.