Fix dialog loaded lifecycle race#260
Merged
Merged
Conversation
|
Diffuse report: AARJAR |
|
Benchmark report:
|
18c0e04 to
7c78c1b
Compare
7c78c1b to
e139f9a
Compare
e139f9a to
128f90d
Compare
CAMOBAP
approved these changes
May 3, 2026
DSergiu
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HCaptchaDialogFragment.onStart()loaded replay so it only runs after the WebView has previously reported a real bridge loadonLoaded()before the JS SDK callsBridgeObject.onLoaded()Why
This is an SDK lifecycle bug, not a live-test-only flake.
onLoaded()has side effects: it emits the loaded listener callback, sets verify params, and auto-executes invisible challenges. Calling it unconditionally fromonStart()can run those effects before web content has actually reported loaded, which matches the generic error 29 failure seen in live CI.The original replay path appears useful for reusing a loaded WebView after reset, so this keeps that behavior but arms it only after a real bridge load.
Testing
./gradlew :sdk:check :test:compileDebugAndroidTestJavaWithJavac