Skip to content

ID-068: Replace dorny/paths-filter with bash path filtering#182

Merged
haalfi merged 1 commit into
masterfrom
claude/id-068-task-0uzlV
Mar 11, 2026
Merged

ID-068: Replace dorny/paths-filter with bash path filtering#182
haalfi merged 1 commit into
masterfrom
claude/id-068-task-0uzlV

Conversation

@haalfi
Copy link
Copy Markdown
Owner

@haalfi haalfi commented Mar 11, 2026

Summary

  • dorny/paths-filter@v3 uses Node.js 20, which GitHub Actions deprecates from 2026-06-02; no Node.js 24-compatible release exists yet (upstream PR #294 still open)
  • Replaced the action with a native bash step: git diff/git ls-files + grep -E — no third-party action runtime required
  • Added fetch-depth: 0 to the changes job checkout so all commits are available for diffing

Test plan

  • Verify the changes job passes on this PR (code files changed → code=true, docs untouched → docs=false)
  • Confirm downstream jobs (lint, typecheck, test, etc.) run as expected
  • Confirm docs jobs are skipped when only code files change
  • Check that gate job reports success

https://claude.ai/code/session_01BzWkJD95UnqdwVcrRq3GVd

dorny/paths-filter@v3 runs on Node.js 20, deprecated on GitHub Actions
from 2026-06-02. No Node.js 24-compatible release exists yet (PR #294
open on the upstream repo at time of fix).

Replace the action in ci.yml with a native bash step:
- checkout with fetch-depth: 0 for full history
- git diff / git ls-files to list changed files per event type
- grep -E patterns matching the original filter rules

No third-party action runtime required; behaviour is identical.

https://claude.ai/code/session_01BzWkJD95UnqdwVcrRq3GVd
Copy link
Copy Markdown
Owner Author

@haalfi haalfi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the full diff. Clean replacement of dorny/paths-filter with native bash — pattern coverage matches, error handling is sound (GHA's default set -eo pipefail), all push/PR/initial-push branches are covered, and no injection risk from the ${{ }} expressions (all GitHub-controlled values). Backlog and ripple check clear. No issues found.

@haalfi haalfi merged commit f2c9d42 into master Mar 11, 2026
19 checks passed
@haalfi haalfi deleted the claude/id-068-task-0uzlV branch March 11, 2026 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants