Fix #29: re-build the KdTree when doing consecutive insert_bulk operations#30
Merged
habedi merged 3 commits intoFeb 20, 2026
Merged
Conversation
efd70c9 to
d34cd9c
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #30 +/- ##
==========================================
+ Coverage 72.52% 73.57% +1.04%
==========================================
Files 10 10
Lines 2038 2100 +62
==========================================
+ Hits 1478 1545 +67
+ Misses 560 555 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
habedi
reviewed
Feb 20, 2026
| let target = target_point_2d(); | ||
| let knn_results = tree.knn_search::<EuclideanDistance>(&target, len_a + len_b); | ||
|
|
||
| assert_eq!( |
Owner
There was a problem hiding this comment.
Hi, can the test be more strict? Right now, it only check the tree includes the expected number of points. It doesn't check if the inserted points actually exists in the tree, for example points "L" to "V" should be in the tree.
For example:
for point in points_first.iter().chain(points_second.iter()) {
assert!(
tree.contains(point),
"Expected tree to contain point after consecutive insert_bulk calls: {:?}",
point
);
Contributor
Author
There was a problem hiding this comment.
Thanks for the suggestion. I've updated the test accordingly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR should fix issue #29