replaced rusoto with aws-sdk - #1926
Merged
Merged
Conversation
sougata-progress
force-pushed
the
sougata/remove_rusoto
branch
3 times, most recently
from
September 2, 2025 23:19
ad5d92c to
ede98ba
Compare
Signed-off-by: sougata-progress <sougatab@progress.com>
sougata-progress
force-pushed
the
sougata/remove_rusoto
branch
from
September 3, 2025 00:19
ede98ba to
15ad3ad
Compare
Signed-off-by: sougata-progress <sougatab@progress.com>
sougata-progress
force-pushed
the
sougata/remove_rusoto
branch
6 times, most recently
from
September 3, 2025 02:25
9871b47 to
6a1b85d
Compare
Signed-off-by: sougata-progress <sougatab@progress.com>
sougata-progress
force-pushed
the
sougata/remove_rusoto
branch
from
September 3, 2025 02:42
6a1b85d to
397e8e4
Compare
sougata-progress
marked this pull request as ready for review
September 3, 2025 02:59
Contributor
Author
|
hi @mwrock can you please check the buildkit failure says cant find builder key: |
mwrock
reviewed
Sep 10, 2025
| Err(err) => panic!("Unable to create Rusoto http client, err = {}", err), | ||
| }; | ||
| let client = S3Client::new_with(http_client, cred_provider, region); | ||
| let client = tokio::runtime::Handle::current().block_on(async { |
Contributor
There was a problem hiding this comment.
looks like this is causing a panic according to the supervisor log in the build artifacts:
panicked at components/builder-api/src/server/services/s3.rs:71:56
Cannot start a runtime from within a runtime. This happens because a function (like `block_on`) attempted to block the current thread while the thread is being used to drive asynchronous tasks.
Contributor
This is fixed now. The problem was in hab itself. Key generation broke with clap v4. |
Signed-off-by: Matt Wrock <matt@mattwrock.com>
mwrock
force-pushed
the
sougata/remove_rusoto
branch
from
September 10, 2025 23:22
2737c17 to
ece629f
Compare
|
mwrock
approved these changes
Sep 11, 2025
chef-expeditor Bot
pushed a commit
that referenced
this pull request
Sep 11, 2025
Obvious fix; these changes are the result of automation not creative thinking.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.