Skip to content

Add aarch64 linux/darwin as default platforms - #2027

Merged
mwrock merged 3 commits into
mainfrom
sbom
Aug 6, 2026
Merged

Add aarch64 linux/darwin as default platforms#2027
mwrock merged 3 commits into
mainfrom
sbom

Conversation

@mwrock

@mwrock mwrock commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

This also fixes hard coded blackduck version.

mwrock added 2 commits July 31, 2026 09:46
Signed-off-by: Matt Wrock <matt@mattwrock.com>
Signed-off-by: Matt Wrock <matt@mattwrock.com>
@mwrock
mwrock requested a review from a team as a code owner August 6, 2026 15:35
Copilot AI lite review requested due to automatic review settings August 6, 2026 15:35

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates default platform targeting for Habitat Builder and adjusts CI workflow version sourcing to align SBOM/BlackDuck inputs with the repository’s VERSION file.

Changes:

  • Add aarch64-darwin and aarch64-linux to the default Builder API target list (Habitat service config).
  • Update the CI main PR stub workflow to detect the version from the repo VERSION file instead of hardcoding it.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
components/builder-api/habitat/default.toml Extends default api.targets to include aarch64 Linux and macOS.
.github/workflows/ci-main-pull-request-stub.yml Switches CI version sourcing to VERSION file (but currently has a YAML input formatting issue).

Comment thread .github/workflows/ci-main-pull-request-stub.yml Outdated
Signed-off-by: Matt Wrock <matt@mattwrock.com>
Copilot AI review requested due to automatic review settings August 6, 2026 15:42

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

Suppressed comments (1)

components/builder-api/habitat/default.toml:4

  • The targets listed in this Habitat default.toml are now significantly broader than the Builder API’s Rust defaults (ApiCfg::default uses only x86_64-linux and x86_64-windows in components/builder-api/src/config.rs:148). This can lead to inconsistent behavior depending on whether Builder is started with the Habitat-provided config vs relying on Rust defaults (e.g., local dev / tests / alternate config-loading paths), so these “default platforms” won’t actually be defaults in all code paths.
targets = ["x86_64-linux", "x86_64-linux-kernel2", "x86_64-windows", "aarch64-darwin", "aarch64-linux"]

@mwrock
mwrock merged commit 11e0196 into main Aug 6, 2026
99 of 112 checks passed
@mwrock
mwrock deleted the sbom branch August 6, 2026 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants