Conversation
Signed-off-by: Matt Wrock <matt@mattwrock.com>
Signed-off-by: Matt Wrock <matt@mattwrock.com>
There was a problem hiding this comment.
Pull request overview
Updates default platform targeting for Habitat Builder and adjusts CI workflow version sourcing to align SBOM/BlackDuck inputs with the repository’s VERSION file.
Changes:
- Add
aarch64-darwinandaarch64-linuxto the default Builder API target list (Habitat service config). - Update the CI main PR stub workflow to detect the version from the repo
VERSIONfile instead of hardcoding it.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| components/builder-api/habitat/default.toml | Extends default api.targets to include aarch64 Linux and macOS. |
| .github/workflows/ci-main-pull-request-stub.yml | Switches CI version sourcing to VERSION file (but currently has a YAML input formatting issue). |
Signed-off-by: Matt Wrock <matt@mattwrock.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
Suppressed comments (1)
components/builder-api/habitat/default.toml:4
- The targets listed in this Habitat default.toml are now significantly broader than the Builder API’s Rust defaults (ApiCfg::default uses only x86_64-linux and x86_64-windows in components/builder-api/src/config.rs:148). This can lead to inconsistent behavior depending on whether Builder is started with the Habitat-provided config vs relying on Rust defaults (e.g., local dev / tests / alternate config-loading paths), so these “default platforms” won’t actually be defaults in all code paths.
targets = ["x86_64-linux", "x86_64-linux-kernel2", "x86_64-windows", "aarch64-darwin", "aarch64-linux"]
rahulgoel1
approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also fixes hard coded blackduck version.