Skip to content

Tchao Bye bye the token file#738

Open
cyr-ius wants to merge 44 commits intohacf-fr:mainfrom
cyr-ius:master
Open

Tchao Bye bye the token file#738
cyr-ius wants to merge 44 commits intohacf-fr:mainfrom
cyr-ius:master

Conversation

@cyr-ius
Copy link
Copy Markdown

@cyr-ius cyr-ius commented Dec 7, 2024

I am the author of the livebox and bouygue api and I propose this redesign, which consists of deleting the token file
You will first have to pass the parameters directly when instantiating the class.
Then make a call to register_app to retrieve the app_token
Once this is done, make a call to the open method and pass the token.

An advantage: the register_app function allows you to retrieve the app_token and possibly save it somewhere, for example in HomeAssistant directly in the config_entry.

All the parameters of the old file can be passed when instantiating the class.

Example:
fbx = Freepybox()
app_token = await fbx.register_app()
await fbx.open(app_token)

I took the opportunity to add the option to use HTTPS or not as well as the verification or not of the certificate.

Fix issue #734 #726

Copy link
Copy Markdown

@Bouska Bouska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cette review arrive tardivement ; mais j'ai besoin d'un changement similaire à celui proposé donc mieux vaut tard que jamais.

cyr-ius and others added 24 commits September 21, 2025 11:12
…acf-fr#746)

Co-authored-by: Bruce LIOU <b.liou@weekera.fr>
Co-authored-by: Quentame <polletquentin74@me.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…r#788)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@cyr-ius
Copy link
Copy Markdown
Author

cyr-ius commented Sep 21, 2025

@Bouska , si une nouvelle version de l'api est publié , je pourrais proposer l"évolution pour le composant au sein de Home Assistant

@cyr-ius cyr-ius requested a review from Bouska September 27, 2025 10:20
@Bouska
Copy link
Copy Markdown

Bouska commented Oct 7, 2025

@cyr-ius je vais m'arrêter dans la review, c'est beaucoup trop le bordel dans les commits : tu mis tes commits, puis tu as mergé master qui a réécrit tes commits, donc tu as remis tes commits 🫨 Repars de master puis cherry-pick tes commits originaux (ou tu peux faire un rebase au scalpel), ensuite je pourrais faire une review sans me croiser tous mes neurones

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants