Open
Conversation
Bouska
reviewed
Jul 21, 2025
Bouska
left a comment
There was a problem hiding this comment.
Cette review arrive tardivement ; mais j'ai besoin d'un changement similaire à celui proposé donc mieux vaut tard que jamais.
…acf-fr#746) Co-authored-by: Bruce LIOU <b.liou@weekera.fr> Co-authored-by: Quentame <polletquentin74@me.com>
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…r#788) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Author
|
@Bouska , si une nouvelle version de l'api est publié , je pourrais proposer l"évolution pour le composant au sein de Home Assistant |
|
@cyr-ius je vais m'arrêter dans la review, c'est beaucoup trop le bordel dans les commits : tu mis tes commits, puis tu as mergé master qui a réécrit tes commits, donc tu as remis tes commits 🫨 Repars de master puis cherry-pick tes commits originaux (ou tu peux faire un rebase au scalpel), ensuite je pourrais faire une review sans me croiser tous mes neurones |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am the author of the livebox and bouygue api and I propose this redesign, which consists of deleting the token file
You will first have to pass the parameters directly when instantiating the class.
Then make a call to register_app to retrieve the app_token
Once this is done, make a call to the open method and pass the token.
An advantage: the register_app function allows you to retrieve the app_token and possibly save it somewhere, for example in HomeAssistant directly in the config_entry.
All the parameters of the old file can be passed when instantiating the class.
Example:
fbx = Freepybox()
app_token = await fbx.register_app()
await fbx.open(app_token)
I took the opportunity to add the option to use HTTPS or not as well as the verification or not of the certificate.
Fix issue #734 #726