Skip to content

Update Gigya API key for de_AT#2107

Merged
epenet merged 2 commits into
hacf-fr:mainfrom
dougculnane:patch-1
May 21, 2026
Merged

Update Gigya API key for de_AT#2107
epenet merged 2 commits into
hacf-fr:mainfrom
dougculnane:patch-1

Conversation

@dougculnane
Copy link
Copy Markdown
Contributor

Thank you very much for your work, which helped us fix our recent openHab Renault binding login issues.

It is strange the Austria should have this exception to the API key.

I have been testing openhab / Renault fixes. On my computer and Austrian car combination the EU key worked and the hard coded value did not.

So I suggest unless there are other users that have found otherwise that the EU API key be used in Austria too.

(REF: openhab/openhab-addons#20773 (comment))

Thank you very much for your work, which helped us fix our recent openHab Renault binding login issues.

It is strange the Austria should have this exception to the API key.

I have been testing openhab / Renault fixes. On my computer and Austrian car combination the EU key worked and the hard coded value did not.  

So I suggest unless there are other users that have found otherwise that the EU API key be using in Austria too.

(REF: openhab/openhab-addons#20773 (comment))
@epenet epenet changed the title Update const.py - EU API key be used in Austria Update Gigya API key for de_AT May 21, 2026
@epenet
Copy link
Copy Markdown
Collaborator

epenet commented May 21, 2026

Please adjust tests accordingly

@epenet epenet marked this pull request as draft May 21, 2026 08:01
@codecov
Copy link
Copy Markdown

codecov Bot commented May 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.06%. Comparing base (c9ff6c4) to head (c87c82c).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2107   +/-   ##
=======================================
  Coverage   87.06%   87.06%           
=======================================
  Files          34       34           
  Lines        2164     2164           
  Branches      248      248           
=======================================
  Hits         1884     1884           
  Misses        198      198           
  Partials       82       82           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@epenet epenet marked this pull request as ready for review May 21, 2026 08:14
@epenet epenet merged commit 1d9a4aa into hacf-fr:main May 21, 2026
20 checks passed
@epenet
Copy link
Copy Markdown
Collaborator

epenet commented May 21, 2026

Thanks @dougculnane

@epenet epenet added the bug Something isn't working label May 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants