refactor: sentry is not mandatory to start the indexer #382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xneves
approved these changes
Jul 24, 2025
| * Sentry configuration | ||
| */ | ||
| const SENTRY_DSN = getRequiredEnvString('SENTRY_DSN'); | ||
| const SENTRY_DSN = process.env['SENTRY_DSN']; |
Contributor
There was a problem hiding this comment.
Have you tested whether process.env is working globally for this process env import?
Contributor
Author
There was a problem hiding this comment.
I haven't tested as mentioned in the PR text Slack chat
Contributor
There was a problem hiding this comment.
My bad, didn't catch that. There was a minor issue, I've fixed and tested it. It's okey now.
0xneves
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposal. I haven't tested the code. Feel free to implement this differently