Skip to content

refactor: improved transfers query for accounts with millions of rows #481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mschead merged 1 commit into from
Sep 2, 2025
Merged

refactor: improved transfers query for accounts with millions of rows #481

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 47 additions & 0 deletions indexer/migrations/20250902193850-modify-transfer-indexes-with-includes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
'use strict';

/** @type {import('sequelize-cli').Migration} */
module.exports = {
async up(queryInterface) {
// Remove old indexes
await queryInterface.removeIndex('Transfers', 'to_acct_idx');
await queryInterface.removeIndex('Transfers', 'from_acct_idx');

// Drop and recreate existing indexes with INCLUDE columns
await queryInterface.removeIndex('Transfers', 'transfers_from_acct_creationtime_id_idx');
await queryInterface.removeIndex('Transfers', 'transfers_to_acct_creationtime_id_idx');

// Create new indexes with INCLUDE columns using raw SQL
await queryInterface.sequelize.query(`
CREATE INDEX transfers_from_acct_creationtime_id_idx ON "Transfers" USING btree (from_acct, creationtime, id)
INCLUDE (amount, "chainId", "transactionId", to_acct, modulename, modulehash, requestkey, "orderIndex", "tokenId")
`);

await queryInterface.sequelize.query(`
CREATE INDEX transfers_to_acct_creationtime_id_idx ON "Transfers" USING btree (to_acct, creationtime, id)
INCLUDE (amount, "chainId", "transactionId", from_acct, modulename, modulehash, requestkey, "orderIndex", "tokenId")
`);
},

async down(queryInterface) {
// Drop the new indexes
await queryInterface.removeIndex('Transfers', 'transfers_from_acct_creationtime_id_idx');
await queryInterface.removeIndex('Transfers', 'transfers_to_acct_creationtime_id_idx');

// Recreate the original indexes without INCLUDE
await queryInterface.addIndex('Transfers', ['from_acct', 'creationtime', 'id'], {
name: 'transfers_from_acct_creationtime_id_idx',
});
await queryInterface.addIndex('Transfers', ['to_acct', 'creationtime', 'id'], {
name: 'transfers_to_acct_creationtime_id_idx',
});

// Recreate the old simple indexes
await queryInterface.addIndex('Transfers', ['to_acct'], {
name: 'to_acct_idx',
});
await queryInterface.addIndex('Transfers', ['from_acct'], {
name: 'from_acct_idx',
});
},
};
90 changes: 50 additions & 40 deletions indexer/src/kadena-server/repository/infra/repository/transfer-db-repository.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,13 +77,6 @@ export default class TransferDbRepository implements TransferRepository {
const queryParams: (string | number | boolean)[] = [limit];
let conditions = '';

if (hasTokenId) {
queryParams.push('marmalade-v2.ledger');
const op = operator(queryParams.length);
queryParams.push('marmalade.ledger');
conditions += `\n${op} transfers.modulename IN ($${queryParams.length - 1}, $${queryParams.length})`;
}

if (after) {
const [creationTime, id] = after.split(':');
queryParams.push(creationTime);
Expand All @@ -103,7 +96,7 @@ export default class TransferDbRepository implements TransferRepository {
if (chainId) {
queryParams.push(chainId);
const op = operator(queryParams.length);
conditions += `\n${op} b."chainId" = $${queryParams.length}`;
conditions += `\n${op} transfers."chainId" = $${queryParams.length}`;
}

if (fungibleName) {
Expand Down Expand Up @@ -136,50 +129,67 @@ export default class TransferDbRepository implements TransferRepository {
conditions += `\n${op} b.hash = $${queryParams.length}`;
}

queryParams.push(hasTokenId ?? false);
const op = operator(queryParams.length);
conditions += `\n${op} transfers."hasTokenId" = $${queryParams.length}`;

let query = '';
if (accountName) {
queryParams.push(accountName);

const columns = `
id,
amount as "transferAmount",
"chainId" as "chainId",
"creationtime" as "creationTime",
"transactionId" as "transactionId",
"from_acct" as "senderAccount",
"to_acct" as "receiverAccount",
modulename as "moduleName",
modulehash as "moduleHash",
requestkey as "requestKey",
"orderIndex",
"tokenId",
"hasTokenId"
`;
query = `
WITH filtered_transfers AS(
SELECT *
FROM (
SELECT *
FROM "Transfers"
WHERE "from_acct" = $${queryParams.length}
UNION ALL
SELECT *
FROM "Transfers"
WHERE "to_acct" = $${queryParams.length}
) transfers
WITH from_transfers AS (
SELECT ${columns}
FROM "Transfers" transfers
${conditions}
AND transfers."from_acct" = $${queryParams.length}
ORDER BY transfers."creationtime" ${order}, transfers.id ${order}
LIMIT 100
),
to_transfers AS (
SELECT ${columns}
FROM "Transfers" transfers
${conditions}
AND transfers."to_acct" = $${queryParams.length}
ORDER BY transfers."creationtime" ${order}, transfers.id ${order}
LIMIT 100
)
select transfers.id as id,
transfers.amount as "transferAmount",
b."chainId" as "chainId",
transfers."creationtime" as "creationTime",
t.id as "transactionId",
SELECT
transfers.*,
b.height as "height",
b.hash as "blockHash",
transfers."from_acct" as "senderAccount",
transfers."to_acct" as "receiverAccount",
transfers.modulename as "moduleName",
transfers.modulehash as "moduleHash",
transfers.requestkey as "requestKey",
transfers."orderIndex" as "orderIndex",
transfers."tokenId" as "tokenId"
from filtered_transfers transfers
join "Transactions" t on t.id = transfers."transactionId"
join "Blocks" b on b."id" = t."blockId"
${conditions}
b.hash as "blockHash"
FROM (
SELECT * FROM from_transfers
UNION ALL
SELECT * FROM to_transfers
) transfers
JOIN "Transactions" t on t.id = transfers."transactionId"
JOIN "Blocks" b on b.id = t."blockId"
ORDER BY transfers."creationTime" ${order}, transfers.id ${order}
LIMIT $1
`;
} else {
query = `
select transfers.id as id,
select transfers.id,
transfers.amount as "transferAmount",
b."chainId" as "chainId",
transfers."chainId" as "chainId",
transfers."creationtime" as "creationTime",
t.id as "transactionId",
transfers."transactionId" as "transactionId",
b.height as "height",
b.hash as "blockHash",
transfers."from_acct" as "senderAccount",
Expand All @@ -191,7 +201,7 @@ export default class TransferDbRepository implements TransferRepository {
transfers."tokenId" as "tokenId"
from "Transfers" transfers
join "Transactions" t on t.id = transfers."transactionId"
join "Blocks" b on b."id" = t."blockId"
join "Blocks" b on b.id = t."blockId"
${conditions}
ORDER BY transfers.creationtime ${order}, transfers.id ${order}
LIMIT $1
Expand Down