forked from hack-rpi/HackRPI-Website-2024
-
Notifications
You must be signed in to change notification settings - Fork 4
Feature/add missing unit tests #85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Jordan231111
wants to merge
20
commits into
main
Choose a base branch
from
feature/add-missing-unit-tests
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts passing, covers critical URL mapping logic
d42c60b
to
c1cac66
Compare
…s for consistency and update background image syntax in sponsors component
61ec079
to
fe80fd7
Compare
c5c4ccf
to
bc53319
Compare
552220a
to
406aa72
Compare
9317dde
to
b9d73b5
Compare
…configuration file
… GitHub Actions workflow to use detailed Prettier options
…t of repository cleanup
This pull request includes several changes across workflows, pre-commit hooks, mock files, and test files. The most significant updates involve removing the linting job from the GitHub Actions workflow, enhancing pre-commit checks, introducing mock implementations for testing, and updating test cases for improved accuracy and coverage. Workflow and Pre-commit Updates:
Mock Implementations for Testing:
Test Enhancements:
Style and Configuration Changes:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a variety of changes, including the addition of mock implementations for testing, updates to existing component mocks, new test cases for components, and improvements to test assertions and styling checks. Below is a categorized summary of the most important changes:
Mock Implementations for Testing
jQuery
andjQuery UI
to facilitate testing, including specific mocks forautocomplete
functionality (__mocks__/jquery.js
,__mocks__/jquery-ui.js
,__mocks__/jquery-ui/ui/widgets/autocomplete.js
). [1] [2] [3]Component Updates
MockFooter
component to include a more detailed structure and updated its mock content to reflect the HackRPI branding (__tests__/__mocks__/mockRegistry.tsx
).New Component Tests
EventCard
component, including functionality for editing, deleting, and toggling visibility of events (__tests__/components/EventCard.test.tsx
).Game Board
component to validate grid rendering, value display, and structural styling (__tests__/components/game/board.test.tsx
).Game Tile
component to verify rendering of different values and corresponding styles (__tests__/components/game/tile.test.tsx
).Improvements to Existing Tests
AboutUs
component tests to improve robustness, including checks for partial matches and updated styling expectations (__tests__/components/about-us.test.tsx
). [1] [2]Footer
component tests to verify new gradient styling and layout classes (__tests__/components/footer.test.tsx
).Event Page
tests to remove an invalid expectation for theFooter
component, which is no longer rendered in the page (__tests__/components/event.test.tsx
).