Even prettier

Author: sezanzeb

backend/src/controllers/rating-controller.ts

@@ -1,4 +1,12 @@
-import { Authorized, JsonController, CurrentUser, Get, Post, Body, Param } from "routing-controllers";
+import {
+  Authorized,
+  JsonController,
+  CurrentUser,
+  Get,
+  Post,
+  Body,
+  Param,
+} from "routing-controllers";
 import { Inject } from "typedi";
 import { UserRole } from "../entities/user-role";
 import { RatingServiceToken, IRatingService } from "../services/rating-service";

backend/src/services/rating-service.ts

@@ -1,7 +1,4 @@
-import {
-  ForbiddenError,
-  NotFoundError,
-} from "routing-controllers";
+import { ForbiddenError, NotFoundError } from "routing-controllers";
 import { Inject, Service, Token } from "typedi";
 import { Repository } from "typeorm";
 import { IService } from ".";

backend/test/controllers/rating-controller.spec.ts

@@ -25,7 +25,6 @@ describe("RatingController", () => {
     ratingService = new MockRatingService();
     settingsService = new MockSettingsService();
     controller = new RatingController(
-      settingsService.instance,
       ratingService.instance,
     );
   });
@@ -85,7 +84,6 @@ describe("RatingController", () => {
         get(target: Function) {
           if (target === RatingController) {
             return new RatingController(
-              settingsService.instance,
               ratingService.instance,
             );
           }

frontend/src/components/base/flex.tsx

@@ -62,7 +62,10 @@ export const FlexRowColumnContainer = styled.div`
 /**
  * A column in a flex row.
  */
-export const BigFlexRowColumnContainer = (props: { children?: React.ReactNode; style?: React.CSSProperties }) => (
+export const BigFlexRowColumnContainer = (props: {
+  children?: React.ReactNode;
+  style?: React.CSSProperties;
+}) => (
   <FlexRowColumnContainer {...props} style={{ ...props.style, flexGrow: 2 }}>
     {props.children}
   </FlexRowColumnContainer>

frontend/src/components/pages/projects.tsx

@@ -31,7 +31,9 @@ const arraySum = (array: number[]) => {
  * for each project.
  */
 const RatingResults = () => {
-  const [ratingResults, setRatingResults] = useState<ProjectRatingResultDTO[]>([]);
+  const [ratingResults, setRatingResults] = useState<ProjectRatingResultDTO[]>(
+    [],
+  );
   const [criteria, setCriteria] = React.useState<CriterionDTO[]>([]);
 
   useEffect(() => {

frontend/src/components/pages/rating-form.tsx

@@ -23,7 +23,11 @@ interface IRatingFormProps {
  * Component that allows users to submit and edit ratings for projects.
  * Only for one criterion, use multiple of this to cover all of them.
  */
-export const RatingForm = ({ rating, criterion, project }: IRatingFormProps) => {
+export const RatingForm = ({
+  rating,
+  criterion,
+  project,
+}: IRatingFormProps) => {
   const loginState = useLoginContext();
   const { user } = loginState;
 

frontend/src/components/pages/read-only-project.tsx

@@ -1,18 +1,11 @@
 import * as React from "react";
-import {
-  FlexRowContainer,
-  Spacer,
-} from "../base/flex";
+import { FlexRowContainer, Spacer } from "../base/flex";
 import { Page } from "./page";
 import { RoundedImage } from "../base/image";
 import { api } from "../../hooks/use-api";
 import { PageHeader } from "../base/page-header";
 import { RatingForm } from "./rating-form";
-import {
-  CriterionDTO,
-  RatingDTO,
-  ProjectDTO,
-} from "../../api/types/dto";
+import { CriterionDTO, RatingDTO, ProjectDTO } from "../../api/types/dto";
 
 /**
  * A settings dashboard to configure all parts of tilt.

frontend/src/components/pages/read-only-team.tsx

@@ -1,8 +1,5 @@
 import * as React from "react";
-import {
-  FlexRowContainer,
-  Spacer,
-} from "../base/flex";
+import { FlexRowContainer, Spacer } from "../base/flex";
 import { Page } from "./page";
 import { Button } from "../base/button";
 import { RoundedImage } from "../base/image";

frontend/src/components/pages/view-project.tsx

@@ -2,10 +2,7 @@ import * as React from "react";
 import { Page } from "./page";
 import { TextInput, TextInputType } from "../base/text-input";
 import { api, useApi } from "../../hooks/use-api";
-import {
-  Switch,
-  FormControlLabel,
-} from "@mui/material";
+import { Switch, FormControlLabel } from "@mui/material";
 import { useLoginContext } from "../../contexts/login-context";
 import { Message } from "../base/message";
 import { UserRole } from "../../api/types/enums";
@@ -81,11 +78,6 @@ const EditProject = ({ project }: { project: ProjectDTO }) => {
     [id, title, description, image, allowRating],
   );
 
-  const { value: _allUsers } = useApi(
-    async (apiClient) => apiClient.getAllUsers(),
-    [],
-  );
-
   const handleSubmit = React.useCallback((event: React.SyntheticEvent) => {
     event.preventDefault();
   }, []);

frontend/src/components/settings/project-rating/rating-criteria-settings.tsx

@@ -28,39 +28,41 @@ interface ICriterionEditorProps {
 /**
  * Edit or delete a single criteria
  **/
-const CriterionEditor = React.memo(({ criterion, onSave, onDelete }: ICriterionEditorProps) => {
-  // Use react.memo to avoid rerendering the component every time a character is typed
-  const [title, setTitle] = useState(criterion.title);
-  const [description, setDescription] = useState(criterion.description);
+const CriterionEditor = React.memo(
+  ({ criterion, onSave, onDelete }: ICriterionEditorProps) => {
+    // Use react.memo to avoid rerendering the component every time a character is typed
+    const [title, setTitle] = useState(criterion.title);
+    const [description, setDescription] = useState(criterion.description);
 
-  return (
-    <Stack direction={{ sm: "column", md: "row" }} spacing={{ xs: 1, sm: 2 }}>
-      <TextField
-        value={title}
-        onChange={(event) => setTitle(event.target.value)}
-        placeholder="title"
-        rows={1}
-      />
-      <TextField
-        value={description}
-        onChange={(event) => setDescription(event.target.value)}
-        placeholder="Description"
-        rows={1}
-        sx={{ flex: 1 }}
-      />
-      <Button
-        fullWidth={false}
-        variant="contained"
-        onClick={() => onSave({ ...criterion, title, description })}
-      >
-        Save
-      </Button>
-      <Button variant="contained" onClick={() => onDelete(criterion)}>
-        Delete
-      </Button>
-    </Stack>
-  );
-});
+    return (
+      <Stack direction={{ sm: "column", md: "row" }} spacing={{ xs: 1, sm: 2 }}>
+        <TextField
+          value={title}
+          onChange={(event) => setTitle(event.target.value)}
+          placeholder="title"
+          rows={1}
+        />
+        <TextField
+          value={description}
+          onChange={(event) => setDescription(event.target.value)}
+          placeholder="Description"
+          rows={1}
+          sx={{ flex: 1 }}
+        />
+        <Button
+          fullWidth={false}
+          variant="contained"
+          onClick={() => onSave({ ...criterion, title, description })}
+        >
+          Save
+        </Button>
+        <Button variant="contained" onClick={() => onDelete(criterion)}>
+          Delete
+        </Button>
+      </Stack>
+    );
+  },
+);
 
 /**
  * A component to edit criteria for rating projects.