rework reviewer UI!! - #432
Merged
Merged
Conversation
Reworks the review interface around the reviewer feedback thread and the
~700 real fines in #this-is-fines.
Fine guardrails
- JustificationLint: blocks the phrasings we were actually fined for
("checks out", "lgtm", "extremely detailed", "not fraud"), live while
typing and re-enforced server-side on approve
- duplicate/double-dip scan across Forge, the Unified DB and Macondo
- new submission checks: still cover image, reachable build proof,
STEP-not-STL, KiCad project files, school/paid work
- blocks self-review and unexplained deflation
Review speed
- Overview tab (journal digest) opens first: weekly roll-up with pace,
gaps, backfilled entries and hour outliers
- journal entries collapse behind an arrow
- per-entry hour approval replaces the free-text evidence box and the flat
hours override, so the justification and the submitted total cannot disagree
- worked examples of fined justifications and their fixes
Also
- fixes the pre-submission check rendering nothing for pre-status results
- StreakService.reconcile_missed_days: 100 queries/~1.1s -> 5/~70ms
- hides Pitch and Description outside tier 1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rework reviewer UI!!