Update club links and add HCB organization link - #180
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates hack.af redirect endpoints to remove legacy leaders.hackclub.com links, route club join links through clubs.hackclub.com, and add a new shortcut redirect for HCB organization pages.
Changes:
- Added
/hcb/:orgredirect tohttps://hcb.hackclub.com/<org>. - Updated
/join/:coderedirect tohttps://clubs.hackclub.com/auth/member?join=<code>. - Removed legacy
leaders.hackclub.com-based redirects (/club/:name,/confirm/:code, old/join/:codetarget).
Suppressed comments (1)
app.js:558
- The join code is inserted into the query string without URL-encoding. If it contains
&,=or other reserved characters, it can inject extra query parameters or yield a malformed redirect. UseURLSearchParams/new URL()(orencodeURIComponent) to build the redirect safely.
app.get("/join/:code", (req, res) => {
res.redirect(302, "https://clubs.hackclub.com/auth/member?join=" + req.params.code);
});
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+548
to
+550
| app.get("/hcb/:org", (req, res) => { | ||
| res.redirect(302, "https://hcb.hackclub.com/" + req.params.org); | ||
| }); |
3kh0
approved these changes
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The commits for this PR have all been made from GitHub Mobile. 😭
hack.af/hcb/...