Standardise API date range validation - #1673
Open
skyfallwastaken wants to merge 2 commits into
Open
Conversation
Amp-Thread-ID: https://ampcode.com/threads/T-01a05ac7-d573-73ef-bcc7-854fec02b38d Co-authored-by: Amp <amp@ampcode.com>
Contributor
Greptile SummaryThe PR centralizes API date-range parsing and validation while retaining endpoint-specific formats, aliases, and defaults.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains. Important Files Changed
Reviews (2): Last reviewed commit: "Validate project discovery date ranges" | Re-trigger Greptile |
Amp-Thread-ID: https://ampcode.com/threads/T-01a05ac7-d573-73ef-bcc7-854fec02b38d Co-authored-by: Amp <amp@ampcode.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the problem
API date ranges are parsed differently across hours, heartbeats, summary and stats endpoints. Malformed values can raise, be ignored or return inconsistent errors, while reversed ranges are accepted. Project discovery also skips malformed aliases and the aggregate stats error responses are documented with the wrong media type.
Describe your changes
Centralise range validation in the existing DateParsing controller concern while preserving each endpoint's documented formats, aliases and defaults. Malformed, incomplete and reversed supplied ranges now return the same 400 JSON error. Validate project discovery aliases at the controller boundary while preserving their precedence and 30-day defaults. Keep the aggregate stats success response as text while documenting its errors as JSON. Add request and Rswag coverage, then regenerate Swagger.
Screenshots / Media
Not applicable. This is an API-only change.