Include the final fractional second in local day ranges

[skyfallwastaken]

Summary of the problem

Today and custom date ranges truncated their upper boundary, losing heartbeats during the final fractional second of a day.

Describe your changes

Use an exclusive next-local-midnight boundary, including across daylight-saving changes. Preserve stored timestamps and deduplication identity; duration output remains in whole seconds.

Screenshots / Media

Not applicable: backend-only changes.

[greptile-apps]

Greptile Summary

Updates local-day filtering to use the next local midnight as an exclusive upper boundary.

• Includes heartbeats occurring during the final fractional second of a day.
• Preserves correct calendar boundaries across daylight-saving transitions.
• Removes the duplicate Heartbeat.today scope in favour of the shared concern.
• Adds regression coverage for both spring and autumn DST transitions.

Confidence Score: 5/5

The PR appears safe to merge, with regression coverage for fractional-second boundaries and DST-aware local days.

No new issues were introduced since the previous review, and the full PR remains consistent with the repository requirements.

Important Files Changed

Filename	Overview
app/models/concerns/time_range_filterable.rb	Uses exclusive next-local-midnight boundaries for today and bounded custom date ranges.
app/models/heartbeat.rb	Removes the duplicate today scope so the shared time-range concern owns the behaviour.
test/models/heartbeat_test.rb	Verifies fractional-second inclusion and exclusive boundaries across both DST transitions.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  A[Local calendar date] --> B[Beginning of local day]
  A --> C[Beginning of next local day]
  B --> D{Heartbeat timestamp}
  C --> D
  D -->|timestamp >= start and timestamp < next midnight| E[Included]
  D -->|otherwise| F[Excluded]

Loading

_{Reviews (2): Last reviewed commit: "Include the final second in local heartb..." | Re-trigger Greptile}