Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove need for hcb stats page for deploy #1456

Merged

Conversation

rluodev
Copy link
Collaborator

@rluodev rluodev commented Jan 14, 2025

No description provided.

@rluodev rluodev linked an issue Jan 14, 2025 that may be closed by this pull request
Copy link

vercel bot commented Jan 14, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
site ❌ Failed (Inspect) Jan 21, 2025 10:15pm

@lachlanjc
Copy link
Member

@rluodev rluodev requested a review from garyhtou January 14, 2025 23:34
props: {
stats
},
revalidate: 10
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good call on the revalidate for get static props.

instead of every 10 seconds. maybe we do once an hour? or even once a day? these numbers don't change that quickly.

})} raised`
)
} catch {
bankData.push('error')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if we pushed nothing? then in the card, we could replace:

data[0] === 'error' ? 'The coolest money thing' : data[0]

with

data[0] || 'The coolest money thing'

@garyhtou
Copy link
Member

lmk once you have the lint errors fixed

@rluodev
Copy link
Collaborator Author

rluodev commented Jan 16, 2025

@garyhtou the lint errors aren't related to my changes, they've been an issue on every pr in this repo

@rluodev rluodev marked this pull request as ready for review January 16, 2025 17:10
@garyhtou garyhtou enabled auto-merge January 21, 2025 22:08
@garyhtou garyhtou added this pull request to the merge queue Jan 21, 2025
Merged via the queue into main with commit a74d2c2 Jan 21, 2025
1 of 4 checks passed
@garyhtou garyhtou deleted the rluodev/1454-hcb-allow-site-to-build-without-hcbs-stats-endpoint branch January 21, 2025 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[HCB] Allow site to build without HCB's stats endpoint
3 participants