remove need for hcb stats page for deploy #1456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
📝 Changed routes:
Commit ebb2216 (https://site-875j9k86j.hackclub.dev). |
garyhtou
reviewed
Jan 14, 2025
| props: { | ||
| stats | ||
| }, | ||
| revalidate: 10 |
There was a problem hiding this comment.
good call on the revalidate for get static props.
instead of every 10 seconds. maybe we do once an hour? or even once a day? these numbers don't change that quickly.
| })} raised` | ||
| ) | ||
| } catch { | ||
| bankData.push('error') |
There was a problem hiding this comment.
What if we pushed nothing? then in the card, we could replace:
data[0] === 'error' ? 'The coolest money thing' : data[0]with
data[0] || 'The coolest money thing'
|
lmk once you have the lint errors fixed |
|
@garyhtou the lint errors aren't related to my changes, they've been an issue on every pr in this repo |
garyhtou
deleted the
rluodev/1454-hcb-allow-site-to-build-without-hcbs-stats-endpoint
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.