chore(project): drop unused project_categories column (follow-up to #360)#549
Draft
dhamariT wants to merge 1 commit into
Draft
chore(project): drop unused project_categories column (follow-up to #360)#549dhamariT wants to merge 1 commit into
dhamariT wants to merge 1 commit into
Conversation
Follow-up to hackclub#360. That PR removes every code reference to project_categories (validation, Gorse payloads, admin/project views) but intentionally leaves the column in place. This migration drops the now-unused column. Must merge after hackclub#360 is deployed. Until hackclub#360 lands, main still reads project_categories at runtime, so dropping the column before then would break project saves.
dhamariT
force-pushed
the
chore/drop-project-categories
branch
from
c5b8a6f to
4b77bfb
Compare
dhamariT
added a commit
to Nullskulls/stardance
that referenced
this pull request
Jun 15, 2026
Resolves the app/models/project.rb conflict from main's hardware_stage feature. Keeps the hardware_stage validations from main and drops the validate :validate_project_categories line (its method was already removed on this branch; project_categories is going away in hackclub#549).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #360. Splitting the destructive migration out so the code ships first.
#360 removes every code reference to
project_categories(the validation, the Gorse payloads, the admin and project views) but deliberately leaves the column in the database. This PR is the second half of that expand/contract: it drops the now-unused column.Order matters. This must merge only after #360 is merged and deployed. Until #360 is live,
mainstill readsproject_categoriesat runtime (the project validation calls it on every save), so dropping the column before that would break project saves. After #360 lands, rebase this on main and merge.The migration is irreversible in practice.
remove_columnis reversible at the schema level so a rollback re-adds the column definition, but the data in it is gone for good.I left this as a draft on purpose so nobody merges it ahead of #360.