Skip to content

Change the displayed label to basename of original image file#26

Open
catroll wants to merge 2 commits into
hackerb9:masterfrom
catroll:master
Open

Change the displayed label to basename of original image file#26
catroll wants to merge 2 commits into
hackerb9:masterfrom
catroll:master

Conversation

@catroll

@catroll catroll commented Jun 20, 2019

Copy link
Copy Markdown

No description provided.

@hackerb9

Copy link
Copy Markdown
Owner

Basename makes sense, although I think I'd put that in processlabel() which is designed to adaptively shorten long filenames.

But why force the notofu font when not everyone will have that installed? Won't that break lsix for many people?

Also, notofu is functional but rather ugly. It is supposed to be a fallback if you have no other font that covers your Unicode range. Did you have problems with one of the other suggested fonts in the comments?

@catroll

catroll commented Jul 5, 2019

Copy link
Copy Markdown
Author

Sorry.
The commit of "Change font family to Noto-Sans-CJK-SC-Regular" is my local change, pull it is a misstake.
I am not really clear how to PR

@hackerb9

hackerb9 commented Jul 6, 2019

Copy link
Copy Markdown
Owner

One way you could do it is to have your local changes in a branch of your repository. Whenever you make a change you want to share, you could do them in main and make a pull request from there. You can also pull the changes into your own local branch so they stay in sync.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants