Games! by gmglbn-0 · Pull Request #23 · hackerembassy/dramma

gmglbn-0 · 2026-04-20T00:40:10Z

added game launcher (uses retroarch), README for easier adjustment of installed games, renovated main page

…elector UI

eupn · 2026-04-21T18:59:55Z

This includes a duplicate /close-hass handler from #22, hopefully there won't be any conflicts after #22 is merged.

Copilot

Pull request overview

Adds an “arcade mode” flow to the kiosk: a revamped main screen with a “Play Games” entrypoint, a new coin-insertion/game-selection UI, and a Rust-side RetroArch/session-timer integration (with time-remaining audio cues).

Changes:

Renovate main UI with feature cards and add a “Play Games” action.
Add InsertCoins page for selecting a game and inserting money to start a timed session.
Add Rust RetroArch process manager + session timers + new “2 min/1 min left” sounds and config for game entries.

Reviewed changes

Copilot reviewed 9 out of 11 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
ui/pages/main.slint	New theme + feature-card layout; adds “Play Games” callback from the main screen.
ui/pages/insert_coins.slint	New page for game selection + money insertion + launch trigger.
ui/main_window.slint	Wires new InsertCoins page into navigation and exposes game/session properties + callbacks.
ui/assets/one_minute_left.wav	Adds 1-minute-remaining announcement audio asset.
src/sound.rs	Extends audio subsystem to support multiple sound events (yippee + time warnings).
src/retroarch.rs	New RetroArch subprocess manager (launch/close).
src/main.rs	Adds `game_handler` to launch RetroArch and manage session countdown/announcements.
src/home_assistant.rs	Switches Chromium to fullscreen; adds (currently unused) HTTP close-listener helper.
src/config.rs	Adds game/RetroArch configuration and new `hass_api_port` field; changes ccTalk port default.
README.md	Documents configuration and game setup for arcade mode.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-21T19:01:34Z

    pub home_assistant_url: String,
+    pub hass_api_port: u16,
    pub cashcode_serial_port: String,
-    /// Serial port for the ccTalk coin acceptor.  Set to `"auto"` (the
-    /// default) to probe all available USB serial ports at startup and on
-    /// every reconnect, which handles `/dev/ttyUSBx` number changes.
    pub cctalk_serial_port: String,


hass_api_port is added to Config, but there are currently no usages in the codebase, so setting it in dramma.toml has no effect. Either wire this into the Home Assistant control path (e.g., the listener) or remove it until it’s actually used to avoid misleading configuration.

Copilot · 2026-04-21T19:01:35Z

+pub fn start_close_listener(port: u16, tx: Sender<()>) {
+    let addr = format!("0.0.0.0:{}", port);
+    let listener = match TcpListener::bind(&addr) {
+        Ok(l) => l,
+        Err(e) => {
+            error!("Failed to bind HASS close listener on {}: {}", addr, e);
+            return;
+        }
+    };
+    info!("🏠 Home Assistant close listener on port {}", port);
+
+    for stream in listener.incoming() {
+        let Ok(mut stream) = stream else {
+            continue;
+        };
+        let mut buf = [0u8; 512];
+        let Ok(n) = stream.read(&mut buf) else {
+            continue;
+        };
+        let request = String::from_utf8_lossy(&buf[..n]);
+        let first_line = request.lines().next().unwrap_or("");
+
+        if first_line.starts_with("POST /close-hass") {
+            info!("🏠 Received remote close-hass request");
+            let _ = tx.send(());
+            let _ = stream.write_all(
+                b"HTTP/1.1 200 OK\r\nAccess-Control-Allow-Origin: *\r\nContent-Length: 2\r\n\r\nOK",
+            );


start_close_listener binds to 0.0.0.0 and accepts unauthenticated POST /close-hass requests while also sending Access-Control-Allow-Origin: *. This exposes a network-accessible control endpoint that can be triggered by any host on the network (and potentially by web content via CORS), effectively allowing remote DoS of the kiosk. Please bind to localhost by default and/or require authentication (shared secret/bearer token), and consider using a minimal HTTP parser that reads the full request before acting.

Copilot · 2026-04-21T19:01:35Z

@@ -1,36 +1,143 @@
 import { LineEdit, Button } from "std-widgets.slint";


LineEdit and Button are imported here but not used anywhere in this file. Please remove unused imports to avoid build/lint warnings and keep the Slint sources tidy.

Suggested change

import { LineEdit, Button } from "std-widgets.slint";

Copilot · 2026-04-21T19:01:35Z

@@ -0,0 +1,256 @@
+import { Button, Palette, ScrollView } from "std-widgets.slint";


ScrollView is imported but not used in this file. Please remove the unused import to avoid Slint compiler warnings.

Suggested change

import { Button, Palette, ScrollView } from "std-widgets.slint";

import { Button, Palette } from "std-widgets.slint";

Copilot · 2026-04-21T19:01:36Z

+                // ── "2 minutes left" milestone ────────────────────────────────
+                if total_secs > 120 {
+                    let fire_at = Duration::from_secs(total_secs - 120);
+                    let t = Timer::default();
+                    t.start(TimerMode::SingleShot, fire_at, || {
+                        info!("🔊 Announcing: 2 minutes left");
+                        crate::sound::play_two_minutes_left();
+                    });
+                    *two_min_timer.borrow_mut() = Some(t);
+                }
+
+                // ── "1 minute left" milestone ─────────────────────────────────
+                if total_secs > 60 {
+                    let fire_at = Duration::from_secs(total_secs - 60);
+                    let t = Timer::default();
+                    t.start(TimerMode::SingleShot, fire_at, || {
+                        info!("🔊 Announcing: 1 minute left");
+                        crate::sound::play_one_minute_left();
+                    });
+                    *one_min_timer.borrow_mut() = Some(t);
+                }


In on_launch_game, the two_min_timer / one_min_timer are only overwritten when total_secs > 120/60. If a previous session scheduled one of these timers and a subsequent (shorter) session does not, the old timer remains alive and may fire during the new session (or after it), playing incorrect announcements. Clear/cancel all existing session timers at the start of each launch (or explicitly set the timer slots to None when the milestone isn’t scheduled) so stale timers can’t trigger.

Copilot · 2026-04-21T19:01:36Z

                "/dev/serial/by-id/usb-Prolific_Technology_Inc._USB-Serial_Controller_D-if00-port0"
                    .to_string(),
-            cctalk_serial_port: "auto".to_string(),
+            cctalk_serial_port: "/dev/ttyUSB0".to_string(),


cctalk_serial_port default was changed to a fixed /dev/ttyUSB0. The ccTalk driver still supports an "auto" mode (see src/cctalk.rs where AUTO_PORT triggers device scanning) to handle /dev/ttyUSBx renumbering on reconnect. Consider keeping "auto" as the default again (or at least documenting the "auto" option in README/config comments), otherwise deployments are more likely to break after USB re-enumeration.

Suggested change

cctalk_serial_port: "/dev/ttyUSB0".to_string(),

cctalk_serial_port: "auto".to_string(),

…ener

gmglbn-0 added 2 commits April 20, 2026 02:41

Add gamemode: RetroArch session management, coin-based timing, game s…

bbe7fee

…elector UI

main window renovation

0f3b56b

gmglbn-0 requested a review from eupn April 20, 2026 00:40

clippy fix

e12dfb2

eupn requested a review from Copilot April 21, 2026 18:56

Copilot started reviewing on behalf of eupn April 21, 2026 18:56 View session

Copilot AI reviewed Apr 21, 2026

View reviewed changes

gmglbn-0 added 2 commits April 26, 2026 12:18

Merge branch 'main' into gamemode

dbdb089

fix: apply PR #23 suggestions, fix Slint syntax, and secure HASS list…

c9bdfd0

…ener

gmglbn-0 merged commit e8f8440 into main Apr 28, 2026
3 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Games! - #23

Games!#23
gmglbn-0 merged 5 commits into
mainfrom
gamemode

gmglbn-0 commented Apr 20, 2026

Uh oh!

eupn commented Apr 21, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Apr 21, 2026

Uh oh!

Copilot AI Apr 21, 2026

Uh oh!

Copilot AI Apr 21, 2026

Uh oh!

Copilot AI Apr 21, 2026

Uh oh!

Copilot AI Apr 21, 2026

Uh oh!

Copilot AI Apr 21, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		@@ -1,36 +1,143 @@
		import { LineEdit, Button } from "std-widgets.slint";

		@@ -0,0 +1,256 @@
		import { Button, Palette, ScrollView } from "std-widgets.slint";

	import { Button, Palette, ScrollView } from "std-widgets.slint";
	import { Button, Palette } from "std-widgets.slint";

	cctalk_serial_port: "/dev/ttyUSB0".to_string(),
	cctalk_serial_port: "auto".to_string(),

Uh oh!

Conversation

gmglbn-0 commented Apr 20, 2026

Uh oh!

eupn commented Apr 21, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Apr 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 21, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants