Skip to content

Feature/#48 drakeredwind01 accomplishment #476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

drakeredwind01
Copy link
Member

Fixes #48

What changes did you make?

added the Accomplishment model with code for the API

Why did you make the changes (we will use this info to test)?

asked to in an issue

Neecolaa and others added 5 commits November 4, 2024 15:56
Added new template for changing tables
updated the update template
Updated update table template
@github-project-automation github-project-automation bot moved this to PR Needs review (automated column, do not place items here manually) in P: PD: Project Board Mar 7, 2025
@fyliu
Copy link
Member

fyliu commented Mar 10, 2025

I think the extra commits in your PR is something I did. I redid some of those commits for formatting after you sync'd your code to them. But that's fine. I or you can get rid of them later.

I think you skipped some of the steps in the tutorial. Most of that document is not optional. The tests have some flexibility if you know better ways to test.

@fyliu fyliu marked this pull request as draft March 28, 2025 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: PR Needs review (automated column, do not place items here manually)
Development

Successfully merging this pull request may close these issues.

Create Table: Accomplishment
4 participants