fix: revise text on page 2 of calc#2628
Merged
Merged
Conversation
entrotech
requested changes
Sep 4, 2025
entrotech
left a comment
entrotech
left a comment
Member
There was a problem hiding this comment.
You cannot do updates to rules by CalculationRule.id, since the id values in the production environment are not always the same across environments. Instead, use Where code = '<code>' and calculationId = 1 in the WHERE clause.
entrotech
approved these changes
Sep 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes did you make?
Why did you make the changes (we will use this info to test)?
Issue-Specific User Account
If you registered a new, temporary TDM User Account for this issue, indicate the
username (i.e., email address) for the account.
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Visuals before changes are applied
Visuals after changes are applied
TODO for Devs
Once the PR has been approved, we have to run the migration on shared DB