Skip to content

Tv/2587 reated on calendar instant close bug#2667

Merged
entrotech merged 2 commits into
developfrom
tv/2587-reated-on-calendar-instant-close-bug
Oct 2, 2025
Merged

Tv/2587 reated on calendar instant close bug#2667
entrotech merged 2 commits into
developfrom
tv/2587-reated-on-calendar-instant-close-bug

Conversation

@Tony-Villa

@Tony-Villa Tony-Villa commented Oct 2, 2025

Copy link
Copy Markdown
Member

What changes did you make?

  • This is kind of an overkill hacky way to solve the issue of the popover immediately closing. I created a ref and a timeout tracker on the table headers to ignore the first outside click event (within 150ms), then restores functionality as expected.

Why did you make the changes (we will use this info to test)?

  • The bug was caused in short browser windows when the date picker rendered the calendar and shifted the entire popover to the side in the middle of a click event, thus causing the popover to register that click event outside of the popover and immediately closing it.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

this cannot be captured via screenshot, please see the video documenting the bug in the issue linked above.

This also fixes issue #2639

@entrotech
entrotech merged commit 804dcd3 into develop Oct 2, 2025
9 checks passed
HyMike pushed a commit that referenced this pull request Oct 3, 2025
* fix: keep from auto closing popover when it shifts

* fix: make sure it can still close popover after supproessing immediate click outside
entrotech added a commit that referenced this pull request Oct 8, 2025
* show edit button only for admin

* show add icon only for admin users

* correct prettier error for MDAddCircle

* add change to admin tooltip where  add icon  upon empty description, cancelling or clicking elsewhere will  no longer display tooltip description.

* add chnage to hide pointer for add  tooltips for  non-admin

* made changes for add icon admin tooltip  upon hover to be a pointer.

* Add Project ID to body on Page 5 and PDF

* add checks for project id in case NAN

* Revert "made changes for add icon admin tooltip  upon hover to be a pointer."

This reverts commit 705e514.

* Revert "add chnage to hide pointer for add  tooltips for  non-admin"

This reverts commit 4da6dcd.

* Revert "add change to admin tooltip where  add icon  upon empty description, cancelling or clicking elsewhere will  no longer display tooltip description."

This reverts commit 84da7d0.

* Revert "correct prettier error for MDAddCircle"

This reverts commit ea156f5.

* Revert "show add icon only for admin users"

This reverts commit 7cc9fc4.

* Revert "show edit button only for admin"

This reverts commit 37772a2.

* Hide edit icon non admin (#2657)

* show edit button only for admin

* show add icon only for admin users

* correct prettier error for MDAddCircle

* add change to admin tooltip where  add icon  upon empty description, cancelling or clicking elsewhere will  no longer display tooltip description.

* add chnage to hide pointer for add  tooltips for  non-admin

* made changes for add icon admin tooltip  upon hover to be a pointer.

* Tv/2587 reated on calendar instant close bug (#2667)

* fix: keep from auto closing popover when it shifts

* fix: make sure it can still close popover after supproessing immediate click outside

* fix: update mobility investment tooltip description (#2651)

* created DRO Selection Modal and changed the DRO displayed in the projects page (#2660)

* Bump vite from 6.3.4 to 6.3.6 in /client (#2634)

Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 6.3.4 to 6.3.6.
- [Release notes](https://github.com/vitejs/vite/releases)
- [Changelog](https://github.com/vitejs/vite/blob/v6.3.6/packages/vite/CHANGELOG.md)
- [Commits](https://github.com/vitejs/vite/commits/v6.3.6/packages/vite)

---
updated-dependencies:
- dependency-name: vite
  dependency-version: 6.3.6
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* fix: universal select style matches input (#2650)

* show edit button only for admin

* show add icon only for admin users

* add chnage to hide pointer for add  tooltips for  non-admin

* made changes for add icon admin tooltip  upon hover to be a pointer.

* moved div into projectID check

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Tony Villa <47979362+Tony-Villa@users.noreply.github.com>
Co-authored-by: Heejung Hong <133067265+heejung-hong@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: John Darragh <darragh@entrotech.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants