Skip to content

Add 'Select all' option with counter to filters#2670

Merged
entrotech merged 10 commits into
developfrom
2630-add-select-all-option
Oct 8, 2025
Merged

Add 'Select all' option with counter to filters#2670
entrotech merged 10 commits into
developfrom
2630-add-select-all-option

Conversation

@nchanyal

@nchanyal nchanyal commented Oct 5, 2025

Copy link
Copy Markdown
Member

What changes did you make?

  • Capitalized the 'clear' option in the filters
  • Added a 'Select all' option with a counter to the filters

Why did you make the changes (we will use this info to test)?

  • To match the design and allow "...users to quickly select or clear all items at once."

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied before-ss
Visuals after changes are applied after-ss-2

Note to reviewer(s):

  • The changes only effect popups which display a list of check boxes
  • The following pages is where the changes show up: My Projects, Manage Submissions, Submissions

@nchanyal nchanyal added the role: front-end Front End Developer label Oct 5, 2025
@anh628
anh628 self-requested a review October 7, 2025 19:45

@anh628 anh628 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but there is a difference in the mockup and what's implemented - mockup shows "Select all" with a lower case a.

@nchanyal nchanyal left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anh628 Nice catch! I replaced the 'A' to be lowercase now.

@nchanyal
nchanyal requested a review from anh628 October 7, 2025 20:36
@nchanyal nchanyal changed the title Add 'Select All' option with counter to filters Add 'Select all' option with counter to filters Oct 7, 2025
@Rabia2219
Rabia2219 requested a review from Tony-Villa October 8, 2025 16:56
@entrotech
entrotech merged commit bc39469 into develop Oct 8, 2025
7 checks passed
@entrotech
entrotech deleted the 2630-add-select-all-option branch October 8, 2025 23:25
@nchanyal
nchanyal removed the request for review from Tony-Villa October 9, 2025 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

role: front-end Front End Developer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dev: Add “Select All” option with counter to filters on all pages with project tables

3 participants