Skip to content

Page 5 footer updates#2687

Merged
entrotech merged 7 commits into
developfrom
page-5-footer-updates
Oct 28, 2025
Merged

Page 5 footer updates#2687
entrotech merged 7 commits into
developfrom
page-5-footer-updates

Conversation

@anh628

@anh628 anh628 commented Oct 13, 2025

Copy link
Copy Markdown
Member

What changes did you make?

  • add snapshot owner information to footer ( [firstName] [lastName], [email])
  • if admin - see approval status in footer

Why did you make the changes (we will use this info to test)?

  • update stored procedure of Project_SelectById to add snapshot store owner's email and approval status in order to pull information to add to the footer

Issue-Specific User Account

  • all users should see snapshot owner information
  • use an admin account in order to see submission status

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied Screenshot 2025-10-13 at 12 26 31 PM Screenshot 2025-10-13 at 12 26 23 PM
Visuals after changes are applied

snapshot that is not yet submitted
Screenshot 2025-10-12 at 10 36 15 PM
Screenshot 2025-10-12 at 10 36 03 PM

Snapshot that was submitted
Screenshot 2025-10-27 at 11 56 55 AM

Screenshot 2025-10-28 at 11 08 44 AM

@anh628 anh628 added role: front-end Front End Developer role: back-end Node/Express Development Task labels Oct 13, 2025
@ExperimentsInHonesty ExperimentsInHonesty added role: database Database Development Task and removed role: back-end Node/Express Development Task labels Oct 14, 2025
@eburdekin
eburdekin self-requested a review October 16, 2025 04:04

@eburdekin eburdekin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per this update, we should have server/report.html and server/report.json in the .gitignore and not included in PRs

@anh628
anh628 requested a review from eburdekin October 22, 2025 06:39

@eburdekin eburdekin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm unable to log in as admin right now to confirm Submission Status in the footer - seems to be a known issue that the wider team is having as well

In the meantime, when you click Continue Without Saving from the login page, you get this error on page 1 of the wizard
Screen Shot 2025-10-22 at 6 19 13 PM

@anh628

anh628 commented Oct 23, 2025

Copy link
Copy Markdown
Member Author

good catch @eburdekin, just push an update

@anh628
anh628 requested a review from eburdekin October 23, 2025 01:52
@Rabia2219
Rabia2219 requested a review from Tony-Villa October 27, 2025 18:03
@ExperimentsInHonesty
ExperimentsInHonesty requested review from ExperimentsInHonesty and removed request for Tony-Villa October 27, 2025 18:31

@ExperimentsInHonesty ExperimentsInHonesty left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the image for the after (that was provided in the issue)

Approved design for PDF Image

This is the image you provided as your after
image

It is missing the Snapshot Submitted date. Please bring that back.

Snapshot Submitted date is also missing from page 5

Approved design for Page 5 image

@anh628
anh628 marked this pull request as draft October 27, 2025 18:53
@anh628

anh628 commented Oct 27, 2025

Copy link
Copy Markdown
Member Author

@ExperimentsInHonesty The snapshot used in the image I provided has a status of pending, it was not submitted yet so does not have a snapshot submitted date.

Double checked with a submitted/withdrawn snapshot and the submitted date is still there.

Screenshot 2025-10-27 at 11 56 55 AM

@anh628
anh628 marked this pull request as ready for review October 27, 2025 19:01
@Rabia2219

Copy link
Copy Markdown
Member

@anh628

Thank you for providing us with the screenshot for Page 5 that shows the Submitted Snapshot date. We also need one for the PDF in order to prepare for the stakeholder deck.

@anh628

anh628 commented Oct 28, 2025

Copy link
Copy Markdown
Member Author

@Rabia2219 I'd updated the description of the pr to include the screenshot of a submitted snapshot pdf printout.

@entrotech
entrotech merged commit 3e8183a into develop Oct 28, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

role: database Database Development Task role: front-end Front End Developer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dev: Add Snapshot Owner & Approval Status at the footer to Page 5 and PDF

5 participants