Skip to content

2719 archived accounts fix missing form label#2798

Merged
entrotech merged 3 commits into
developfrom
2719_archived_accounts_fix_missing_form_label
Dec 4, 2025
Merged

2719 archived accounts fix missing form label#2798
entrotech merged 3 commits into
developfrom
2719_archived_accounts_fix_missing_form_label

Conversation

@HyMike

@HyMike HyMike commented Nov 18, 2025

Copy link
Copy Markdown
Member

What changes did you make?

  • Fixed a WAVE accessibility error for a missing form label on the search input. Added a id="searchString" on the input to associate the label. Initially, I used the sr-only class on the label, which hid the 'search by user' text visually. Then I removed the sr-only so the label is visible while maintaining accessibility, Since the with htmlFor is already accessible to screen readers.

Why did you make the changes (we will use this info to test)?

  • To be WCAG 2.2 compliance

Issue-Specific User Account

If you registered a new, temporary TDM User Account for this issue, indicate the
username (i.e., email address) for the account.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied Screenshot 2025-11-17 at 7 14 49 PM
Visuals after changes are applied Screenshot 2025-11-18 at 11 17 02 AM

@rayneng rayneng left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adding id="searchString" to <input> correctly matches the input up with the label. Screen readers will read "Search for user" when hovering over this form element, which is the desired behavior.

@rayneng

rayneng commented Nov 22, 2025

Copy link
Copy Markdown
Member

Note for merge team, please hold off on merge until @HyMike marks off all completed action items.
...
Michael I've provided my review but I need you to complete the action items so PMs know you obtained accessibility lead approval (@geolunalg or myself). We will revisit these tickets in the future to confirm we followed our procedures correctly.

Missing Action Items

image

@HyMike

HyMike commented Nov 22, 2025

Copy link
Copy Markdown
Member Author

Completed, Thanks.

@entrotech
entrotech merged commit bf59d36 into develop Dec 4, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dev: WAVE Page Audit: View Archived Accounts

3 participants