feature/dev 1879 improve contrast on certain elements #1899
+28
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: stanley2058 <stanley2058@yahoo.com.tw>
Signed-off-by: stanley2058 <stanley2058@yahoo.com.tw>
There was a problem hiding this comment.
Pull Request Overview
This pull request improves the contrast of UI elements, particularly enhancing dark mode readability by adding the one-dark.css file and making various theme adjustments.
- Adds one-dark.css to the webpack build for updated dark mode support
- Improves contrast for key UI components such as link buttons and theme names
Files not reviewed (3)
- public/css/codemirror-extend/one-dark.css: Language not supported
- public/css/extra.css: Language not supported
- public/css/index.css: Language not supported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve contrast of UI elements:
The link buttons in the navbar, last changed at, and the action button on the top right are now more visible in dark mode.
Before:
After:
The color of active line is also updated:
(Before)
(After)