Skip to content

Conversation

@decrypto27
Copy link

@decrypto27 decrypto27 commented Jan 3, 2026

Replaces the incorrect variable reference 'full_face_poly' with the correct local variable 'face_outline_points' in the convexHull calculation.

Summary by Sourcery

Bug Fixes:

  • Resolve NameError and incorrect variable usage in create_face_mask by using the local face outline points for convex hull calculation.

Replaces the incorrect variable reference 'full_face_poly' with the correct local variable 'face_outline_points' in the convexHull calculation.
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jan 3, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Fixes a NameError in create_face_mask by using the correct local variable for convex hull computation, ensuring the face mask hull is computed from the intended outline points.

File-Level Changes

Change Details Files
Use the correct landmark array when computing the convex hull for the face mask.
  • Replace the incorrect variable reference in the convexHull call with the existing local variable holding the face outline points
  • Ensure convex hull is computed from the intended face outline landmarks to avoid NameError and potential runtime failures
modules/processors/frame/face_swapper.py

Possibly linked issues

  • #N/A: PR directly fixes the issue’s NameError by replacing full_face_poly with face_outline_points in convexHull call.
  • #(unprovided): The PR directly fixes the NameError from using 'full_face_poly' instead of 'face_outline_points' in create_face_mask.

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@decrypto27
Copy link
Author

Can someone review this ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant