CreateAccount Activity #28
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # app/src/main/res/values/strings.xml # app/src/main/res/values/styles.xml
krharsh17
reviewed
Jun 24, 2020
Member
There was a problem hiding this comment.
Hey @igrishi It looks like your PR is not updated to the latest changes in the master branch. Could you please rebase/update your branch with master? Its not possible to review in the current state as some of the changes that are being shown in the diff are already present in the master branch.
Contributor
Author
|
@krharsh17 sir i had rebase my branch it's showing that current branch is up to date. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
there are some missing values in styles and strings file for createaccount and editprofile layouts so i added those files and fixed some other issues