Adds new integration [Patafoin/ha-my-music-library]#6584
Conversation
|
Thank you for submitting your repository to HACS (Home Assistant Community Store). Your submission is in the review queue: You can view the current queue here. Pull requests are processed in the order they were created, oldest first. What to avoid during review:
If you need to make changes: About draft pull requests: What happens next:
|
Fixed the integration sort
frenck
left a comment
There was a problem hiding this comment.
Hi @Patafoin, thanks for the submission! 👋
A couple of items need to be addressed before this can be added to the default catalog:
custom_components/my_music_library/manifest.jsonhascodeowners: []. Please add your GitHub handle as the codeowner ("codeowners": ["@Patafoin"]) so there's a maintainer on record for this integration.manifest.jsondocumentationis set to"https://github.com/your-user/my-music-library", which is the cookiecutter placeholder. Home Assistant surfaces this link on the integration page, so users clicking it from a real install would land on a 404. It should point athttps://github.com/Patafoin/ha-my-music-library. While you're there, please also add an"issue_tracker"key, typicallyhttps://github.com/Patafoin/ha-my-music-library/issues.- In
custom_components/my_music_library/const.py,ICON_URLis set to/api/config/custom_components/my_music_library/icon, and__init__.pyregisters it viaasync_register_static_paths. That path sits inside Home Assistant's reserved/api/config/namespace, and static paths bypass authentication. Please move that path under your integration's own namespace, for example/my_music_library/icon.png, so it doesn't collide with the HA config API and isn't served unauthenticated under an/api/...URL.
A few smaller heads-ups worth fixing in the same release (not blockers on their own):
- The five
HomeAssistantViewsubclasses inapi.pyregister their URLs under/api/my_music_library/*. They all setrequires_auth = Trueso there is no auth bypass, but the convention for custom integrations is to host endpoints outside the/api/namespace, for example under/my_music_library/.... - The icon assets currently live at
custom_components/my_music_library/icon.pngandicon.svg. Since HA 2026.3 the supported location iscustom_components/my_music_library/brand/withicon.png,icon@2x.png,logo.png,logo@2x.png. The old root-levelicon.pngstill works on older HA versions but is being phased out. - The README header has a
version-2.7.0shields badge while the release isv2.8.2. Probably an artifact from the badge being hand-edited.
Once the three items above are addressed, push a new release and re-request review.
../Frenck
Blogging my personal ramblings at frenck.dev
frenck
left a comment
There was a problem hiding this comment.
Hi @Patafoin, the v3.0.0 release covers the items from the earlier review.
Approving now.
../Frenck
Blogging my personal ramblings at frenck.dev|
Congratulations! Your repository has been added to HACS 🎉 Your repository has been approved: Resources: Thank you for contributing to the Home Assistant community! 🎉 |
* Add Patafoin/ha-my-music-library * moved integration for sort action Fixed the integration sort --------- Co-authored-by: Steeve Le Dréau <zaxtfh@hotmail.com> Co-authored-by: Franck Nijhof <git@frenck.dev>
* Add Patafoin/ha-my-music-library * moved integration for sort action Fixed the integration sort --------- Co-authored-by: Steeve Le Dréau <zaxtfh@hotmail.com> Co-authored-by: Franck Nijhof <git@frenck.dev>
Checklist
Links
Link to current release: https://github.com/Patafoin/ha-my-music-library/releases/tag/v2.8.2
Link to successful HACS action (without the
ignorekey): https://github.com/Patafoin/ha-my-music-library/actions/runs/23653664484Link to successful hassfest action (if integration): https://github.com/Patafoin/ha-my-music-library/actions/runs/23653664477