Skip to content

Adds new integration [Patafoin/ha-my-music-library]#6584

Merged
frenck merged 9 commits into
hacs:masterfrom
Patafoin:add-my-music-library
May 20, 2026
Merged

Adds new integration [Patafoin/ha-my-music-library]#6584
frenck merged 9 commits into
hacs:masterfrom
Patafoin:add-my-music-library

Conversation

@Patafoin

Copy link
Copy Markdown
Contributor

Checklist

  • I've read the publishing documentation.
  • I've added the HACS action to my repository.
  • I've added the hassfest action to my repository.
  • The actions are passing without any disabled checks in my repository.
  • I've added a link to the action run on my repository below in the links section.
  • I've created a new release of the repository after the validation actions were run successfully.

Links

Link to current release: https://github.com/Patafoin/ha-my-music-library/releases/tag/v2.8.2
Link to successful HACS action (without the ignore key): https://github.com/Patafoin/ha-my-music-library/actions/runs/23653664484
Link to successful hassfest action (if integration): https://github.com/Patafoin/ha-my-music-library/actions/runs/23653664477

@hacs-bot hacs-bot Bot changed the title Add Patafoin/ha-my-music-library Adds new integration [Patafoin/ha-my-music-library] Mar 27, 2026
@hacs-bot

hacs-bot Bot commented Mar 27, 2026

Copy link
Copy Markdown

Thank you for submitting your repository to HACS (Home Assistant Community Store).

Your submission is in the review queue:
Your repository is waiting to be reviewed and included in HACS.

You can view the current queue here. Pull requests are processed in the order they were created, oldest first.

What to avoid during review:
To help reviewers work efficiently, don't do the following:

  • Comment on the pull request - The reviewer will contact you when they have feedback or questions.
  • Open a new pull request - This won't speed up the process and creates duplicate work.
  • Ask followers to comment on the pull request - This won't speed up the process and may delay your review.
  • Merge in the default branch - Only do this if a maintainer asks you to resolve a merge conflict.

If you need to make changes:
You can continue updating your repository while waiting for review. Changes to your repository will be reflected when the reviewer examines it. Only comment on the pull request if you need to withdraw your submission or have critical information for reviewers.

About draft pull requests:
Draft pull requests aren't included in the review queue. Your pull request may be marked as draft by a reviewer if issues need to be addressed. Once you've resolved all issues, mark it as ready for review to re-enter the queue.

What happens next:
Once a reviewer examines your submission, they'll either:

  • Approve and merge your pull request if everything meets the requirements
  • Request changes or ask questions if adjustments are needed

@frenck frenck left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Patafoin, thanks for the submission! 👋

A couple of items need to be addressed before this can be added to the default catalog:

  1. custom_components/my_music_library/manifest.json has codeowners: []. Please add your GitHub handle as the codeowner ("codeowners": ["@Patafoin"]) so there's a maintainer on record for this integration.
  2. manifest.json documentation is set to "https://github.com/your-user/my-music-library", which is the cookiecutter placeholder. Home Assistant surfaces this link on the integration page, so users clicking it from a real install would land on a 404. It should point at https://github.com/Patafoin/ha-my-music-library. While you're there, please also add an "issue_tracker" key, typically https://github.com/Patafoin/ha-my-music-library/issues.
  3. In custom_components/my_music_library/const.py, ICON_URL is set to /api/config/custom_components/my_music_library/icon, and __init__.py registers it via async_register_static_paths. That path sits inside Home Assistant's reserved /api/config/ namespace, and static paths bypass authentication. Please move that path under your integration's own namespace, for example /my_music_library/icon.png, so it doesn't collide with the HA config API and isn't served unauthenticated under an /api/... URL.

A few smaller heads-ups worth fixing in the same release (not blockers on their own):

  • The five HomeAssistantView subclasses in api.py register their URLs under /api/my_music_library/*. They all set requires_auth = True so there is no auth bypass, but the convention for custom integrations is to host endpoints outside the /api/ namespace, for example under /my_music_library/....
  • The icon assets currently live at custom_components/my_music_library/icon.png and icon.svg. Since HA 2026.3 the supported location is custom_components/my_music_library/brand/ with icon.png, icon@2x.png, logo.png, logo@2x.png. The old root-level icon.png still works on older HA versions but is being phased out.
  • The README header has a version-2.7.0 shields badge while the release is v2.8.2. Probably an artifact from the badge being hand-edited.

Once the three items above are addressed, push a new release and re-request review.

../Frenck

                       

Blogging my personal ramblings at frenck.dev

@hacs-bot hacs-bot Bot marked this pull request as draft May 18, 2026 20:18
@Patafoin Patafoin marked this pull request as ready for review May 19, 2026 19:13
@Patafoin Patafoin requested a review from frenck May 19, 2026 20:41

@frenck frenck left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Patafoin, the v3.0.0 release covers the items from the earlier review.

Approving now.

../Frenck

                       

Blogging my personal ramblings at frenck.dev

@frenck frenck merged commit 9e3091c into hacs:master May 20, 2026
11 checks passed
@hacs-bot

hacs-bot Bot commented May 20, 2026

Copy link
Copy Markdown

Congratulations! Your repository has been added to HACS 🎉

Your repository has been approved:
Your repository has been successfully merged into the HACS default repository list.
It might take up to 8 hours before your repository appears in HACS for users.

Resources:

Thank you for contributing to the Home Assistant community! 🎉

memphi2 pushed a commit to memphi2/default that referenced this pull request May 21, 2026
* Add Patafoin/ha-my-music-library

* moved integration for sort action

Fixed the integration sort

---------

Co-authored-by: Steeve Le Dréau <zaxtfh@hotmail.com>
Co-authored-by: Franck Nijhof <git@frenck.dev>
cpuwolf pushed a commit to cpuwolf/default that referenced this pull request Jun 6, 2026
* Add Patafoin/ha-my-music-library

* moved integration for sort action

Fixed the integration sort

---------

Co-authored-by: Steeve Le Dréau <zaxtfh@hotmail.com>
Co-authored-by: Franck Nijhof <git@frenck.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants