Skip to content

Add group/curve trait to bip-340 #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add group/curve trait to bip-340 #17

wants to merge 4 commits into from

Conversation

@cmester0
Copy link

@cmester0 cmester0 commented Mar 12, 2024

No description provided.

@cmester0 cmester0 marked this pull request as ready for review March 14, 2024 17:54
@cmester0
Copy link
Author

cmester0 commented Mar 14, 2024 •
edited
Loading

We could switch to using the zkcrypto/group trait, instead of using nat_mod, however it does use mutable borrows, which does not fit well with Hax.

@tarcieri
Copy link

tarcieri commented Mar 15, 2024

however it does use mutable borrows

Are you talking about for the *Assign traits? Those are straight out of core::ops and all have non-*Assign variants which use immutable borrows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cmester0 @tarcieri