Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
1.510.0->1.512.05.25.4->5.25.58.0.1->8.0.21.73.2->1.74.0🔧 This Pull Request updates lock files to use the latest dependency versions.
Release Notes
aws/aws-sdk-ruby (aws-sdk-ec2)
v1.512.0v1.511.0minitest/minitest (minitest)
v5.25.5Compare Source
rails/rails (railties)
v8.0.2: 8.0.2Compare Source
Active Support
Fix setting
to_time_preserves_timezonefromnew_framework_defaults_8_0.rb.fatkodima
Fix Active Support Cache
fetch_multiwhen local store is active.fetch_multinow properly yield to the provided block for missing entriesthat have been recorded as such in the local store.
Jean Boussier
Fix execution wrapping to report all exceptions, including
Exception.If a more serious error like
SystemStackErrororNoMemoryErrorhappens,the error reporter should be able to report these kinds of exceptions.
Gannon McGibbon
Fix
RedisCacheStoreandMemCacheStoreto also handle connection pool related errors.These errors are rescued and reported to
Rails.error.Jean Boussier
Fix
ActiveSupport::Cache#read_multito respect version expiry when using local cache.zzak
Fix
ActiveSupport::MessageVerifierandActiveSupport::MessageEncryptorconfiguration ofon_rotationcallback.Now both work as documented.
Jean Boussier
Fix
ActiveSupport::MessageVerifierto always be able to verify both URL-safe and URL-unsafe payloads.This is to allow transitioning seemlessly from either configuration without immediately invalidating
all previously generated signed messages.
Jean Boussier, Florent Beaurain, Ali Sepehri
Fix
cache.fetchto honor the provided expiry when:race_condition_ttlis used.In the above example, the final cache entry would have a 10 seconds TTL instead
of the requested 1 hour.
Dhia
Better handle procs with splat arguments in
set_callback.Radamés Roriz
Fix
String#mb_charsto not mutate the receiver.Previously it would call
force_encodingon the receiver,now it dups the receiver first.
Jean Boussier
Improve
ErrorSubscriberto also mark error causes as reported.This avoid some cases of errors being reported twice, notably in views because of how
errors are wrapped in
ActionView::Template::Error.Jean Boussier
Fix
Module#module_parent_nameto return the correct name after the module has been named.When called on an anonymous module, the return value wouldn't change after the module was given a name
later by being assigned to a constant.
Jean Boussier
Active Model
Active Record
Fix inverting
rename_enum_valuewhen:from/:toare provided.fatkodima
Prevent persisting invalid record.
Edouard Chin
Fix inverting
drop_tablewithout options.fatkodima
Fix count with group by qualified name on loaded relation.
Ryuta Kamizono
Fix
sumwith qualified name on loaded relation.Chris Gunther
The SQLite3 adapter quotes non-finite Numeric values like "Infinity" and "NaN".
Mike Dalessio
Handle libpq returning a database version of 0 on no/bad connection in
PostgreSQLAdapter.Before, this version would be cached and an error would be raised during connection configuration when
comparing it with the minimum required version for the adapter. This meant that the connection could
never be successfully configured on subsequent reconnection attempts.
Now, this is treated as a connection failure consistent with libpq, raising a
ActiveRecord::ConnectionFailedand ensuring the version isn't cached, which allows the version to be retrieved on the next connection attempt.
Joshua Young, Rian McGuire
Fix error handling during connection configuration.
Active Record wasn't properly handling errors during the connection configuration phase.
This could lead to a partially configured connection being used, resulting in various exceptions,
the most common being with the PostgreSQLAdapter raising
undefined methodkey?' for nilorTypeError: wrong argument type nil (expected PG::TypeMap)`.Jean Boussier
Fix a case where a non-retryable query could be marked retryable.
Hartley McGuire
Handle circular references when autosaving associations.
zzak
PoolConfig no longer keeps a reference to the connection class.
Keeping a reference to the class caused subtle issues when combined with reloading in
development. Fixes #54343.
Mike Dalessio
Fix SQL notifications sometimes not sent when using async queries.
In rare circumstances and under the right race condition, Active Support notifications
would no longer be dispatched after using an asynchronous query.
This is now fixed.
Edouard Chin
Fix support for PostgreSQL enum types with commas in their name.
Arthur Hess
Fix inserts on MySQL with no RETURNING support for a table with multiple auto populated columns.
Nikita Vasilevsky
Fix joining on a scoped association with string joins and bind parameters.
The above example would result in
ActiveRecord::StatementInvalidbecause theactivescope bind parameters would be lost.Jean Boussier
Fix a potential race condition with system tests and transactional fixtures.
Sjoerd Lagarde
Fix autosave associations to no longer validated unmodified associated records.
Active Record was incorrectly performing validation on associated record that
weren't created nor modified as part of the transaction:
Jean Boussier
Remember when a database connection has recently been verified (for
two seconds, by default), to avoid repeated reverifications during a
single request.
This should recreate a similar rate of verification as in Rails 7.1,
where connections are leased for the duration of a request, and thus
only verified once.
Matthew Draper
Action View
Respect
html_options[:form]whencollection_checkboxesgenerates thehidden
<input>.Riccardo Odone
Layouts have access to local variables passed to
render.This fixes #31680 which was a regression in Rails 5.1.
Mike Dalessio
Argument errors related to strict locals in templates now raise an
ActionView::StrictLocalsError, and all other argument errors are reraised as-is.Previously, any
ArgumentErrorraised during template rendering was swallowed during strictlocal error handling, so that an
ArgumentErrorunrelated to strict locals (e.g., a helpermethod invoked with incorrect arguments) would be replaced by a similar
ArgumentErrorwith anunrelated backtrace, making it difficult to debug templates.
Now, any
ArgumentErrorunrelated to strict locals is reraised, preserving the originalbacktrace for developers.
Also note that
ActionView::StrictLocalsErroris a subclass ofArgumentError, so any existingcode that rescues
ArgumentErrorwill continue to work.Fixes #52227.
Mike Dalessio
Fix stack overflow error in dependency tracker when dealing with circular dependencies
Jean Boussier
Action Pack
Improve
with_routingtest helper to not rebuild the middleware stack.Otherwise some middleware configuration could be lost.
Édouard Chin
Add resource name to the
ArgumentErrorthat's raised when invalid:onlyor:exceptoptions are given to#resourceor#resourcesThis makes it easier to locate the source of the problem, especially for routes drawn by gems.
Before:
After:
Jeremy Green
Fix
url_forto handle:path_paramsgracefully when it's not aHash.Prevents various security scanners from causing exceptions.
Martin Emde
Fix
ActionDispatch::Executorto unwrap exceptions like other error reporting middlewares.Jean Boussier
Active Job
Action Mailer
Action Cable
Active Storage
A Blob will no longer autosave associated Attachment.
This fixes an issue where a record with an attachment would have
its dirty attributes reset, preventing your
after commitcallbackson that record to behave as expected.
Note that this change doesn't require any changes on your application
and is supposed to be internal. Active Storage Attachment will continue
to be autosaved (through a different relation).
Edouard-chin
Action Mailbox
Action Text
Railties
Fix Rails console to load routes.
Otherwise
*_pathand*urlmethods are missing on theappobject.Édouard Chin
Update
rails new --minimaloptionExtend the
--minimalflag to exclude recently added features:skip_brakeman,skip_ci,skip_docker,skip_kamal,skip_rubocop,skip_solidandskip_thruster.eelcoj
Use
secret_key_basefrom ENV or credentials when present locally.When ENV["SECRET_KEY_BASE"] or
Rails.application.credentials.secret_key_baseis set for test ordevelopment, it is used for the
Rails.config.secret_key_base,instead of generating a
tmp/local_secret.txtfile.Petrik de Heus
Guides
rubocop/rubocop (rubocop)
v1.74.0Compare Source
New features
Style/ComparableBetween. ([@lovro-bikic][])Style/CommentedKeyword. ([@dak2][])Bug fixes
Lint/SharedMutableDefaultwhencapacitykeyword argument is used. ([@koic][])Style/DoubleNegationwhen callingdefine_method/define_singleton_methodwith a numblock. ([@earlopain][])Lint/ReturnInVoidContextwhen returning out of a block. ([@earlopain][])Lint/UselessConstantScopingfor constants defined inclass << self. ([@earlopain][])Lint/NonLocalExitFromIteratorwith numblocks. ([@earlopain][])Style/RedundantCurrentDirectoryInPathwhen using a complex current directory path inrequire_relative. ([@koic][])Lint/LiteralAsConditionwhen the literal is followed byreturn,break, ornext. ([@earlopain][])Style/MethodCallWithArgsParentheseswithEnforcedStyle: omit_parenthesesstyle and numblocks. ([@earlopain][])rubocop-railsorrubocop-performanceextraction, even if they are already part of the Gemfile. ([@earlopain][])Lint/RedundantCopDisableDirectiveto register an offense when cop names are given with improper casing. ([@dvandersluis][])Style/RescueModifierwhen using parallel assignment and the right-hand-side is not a bracketed array. ([@earlopain][])Changes
EnforcedStyleForClassesandEnforcedStyleForModulesconfiguration options toStyle/ClassAndModuleChildren. ([@dvandersluis][])Mode: conservativeconfiguration toStyle/FormatStringTokento make the cop only register offenses for strings given toprintf,sprintf,format, and%. ([@dvandersluis][])TLS1_1andTLS1_2by default inNaming/VariableNumberto accommodate OpenSSL version parameter names. ([@koic][])Lint/RedundantTypeConversionaware of redundantto_d. ([@koic][])Configuration
📅 Schedule: Branch creation - "before 4am on monday" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
This PR was generated by Mend Renovate. View the repository job log.