Biometrics #1113
Open
Biometrics #1113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were two bugs with TextSwitchPreference: 1. The switch display was consuming click events when they should have been given to the parent. 2. The materialSwitch variable became stale, and state updates didn't propagate correctly. onBindViewHolder is always called when the underlying Preference updates, so we can fix these two issues in in. Afterwards, state should always be in sync.
If the activity was quickly closed, then onDestroyed might be called without onStart, leading to an attempt at unregistering a non-existent receiver and causing a crash.
This adds a simple biometric lock to the whole application. Once toggled in settings, it requires a fingerprint/password/other authentication method to be used before the app can be opened. Until it's closed, the app will stay permanently unlocked. This doesn't implement locking when moving to a different window / after a certain period of time, account-specific locks, or wiping auth data when biometrics change.
uellenberg
force-pushed
the
biometrics
branch
from
3739233 to
9abcf49
Compare
Author
|
Fixes #1096 @zhwanng I'm interested in getting a security feature like this into the Seadroid app. Please let me know if you have any feedback/concerns. The biggest issue right now is that MainActivity won't be opened until the user authenticates, so all of the code to register with the server and handle background backups won't be called. I think it's desirable to not force the user to authenticate every time they reboot their device in order for the background backup to work. I'm thinking of moving some of the code out of MainActivity and into the application, that way it always runs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a simple biometric lock to the whole application. Once toggled in settings, it requires a fingerprint/password/other authentication method to be used before the app can be opened.
Until it's closed, the app will stay permanently unlocked. This doesn't implement locking when moving to a different window / after a certain period of time, account-specific locks, or wiping auth data when biometrics change.