This PR allows the user to pass an optional filename argument #3846
+27
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is now possible to pass an optional filename argument for specifying the name of the presentation html file. If no argument is passed, the default behavior is the same, i.e. open index.html. If started with npm start -- --file=presentation.html then the file presentation.html is served. This file might be located in a different directory. Makes it easy to store separate presentations in another directory or even repository.
Author
|
Hi @hakimel and all contributors. Thanks a lot for this very nice piece of software 🥇 |
Using process.cwd() as the server root to correctly handle external presentation files.
hansmannj
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is now possible to pass an optional filename argument for specifying the name of the presentation html file. If no argument is passed, the default behavior is the same, i.e. open index.html. If started with
npm start -- --file=presentation.htmlthen the file presentation.html is served. This file might be located in a different directory. Makes it easy to store separate presentations in another directory or even repository.