Switch from pytest-vcr to pytest-recording
#407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pytest-recording stores cassettes for each module in its own directory. Using "vcr_cassette_dir" fixture, we override it to use the old behavior.
The former is unmaintained upstream. Fixes: halcy#406
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #407 +/- ##
=======================================
Coverage 89.15% 89.15%
=======================================
Files 34 34
Lines 4492 4492
=======================================
Hits 4005 4005
Misses 487 487 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
oh this rules, thank you. I'll try if that also fixes the recording issue / if recording still works, though not this week, I am Entirely Dead after attenting revision! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #406