You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@copilot can you please fix the build error arising from the LLVM version upgrade? Change the code to use the new APIs, gated appropriately by version-checking preprocessor directives to maintain compatibility with older major versions.
@copilot can you please fix the build error arising from the LLVM version upgrade? Change the code to use the new APIs, gated appropriately by version-checking preprocessor directives to maintain comp...
Fixed in b0cfaa3. The linkerBuilder lambda for ObjectLinkingLayer already had the JITLinkMemoryManager& parameter in the LLVM 23 signature but it was anonymous and unused. In LLVM 23, the single-argument ObjectLinkingLayer(ExecutionSession&) constructor was removed and a memory manager is now required. The fix names the parameter memMgr and passes it to the constructor under #if LLVM_VERSION >= 230, preserving the old behavior for older LLVM versions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated upgrade via
uv lock -P halide-llvm.